Feeling Lucky
?
[#10066] - Fix UNC path test on windows installations
- Fixed in Code Base
- 8 May 2016
- Medium
- Build: staging
- # 10066
- Diff
- izharaazmi:patch-8
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Previously it would raise undefined string offset error when the passed value is "\" only, as there was no length check for the $path variable.
Testing Instructions
If testing on Windows:
JPath::clean('\\');If testing on any OS, including Windows:
JPath::clean('\\', '\\');You can see the php error message: undefined string offset 1
Make sure you have error reporting enabled when you test this.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Libraries |
zero-24
- comment
- 7 May 2016
I have tested this item 
successfully on ccf7ce1
Thanks. works here with the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10066.
zero-24
- comment
- 7 May 2016
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10066.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
Kubik-Rubik
- comment
- 8 May 2016
Thank you @izharaazmi and testers!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 13:44:10 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on ccf7ce1
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10066.