? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
23 Apr 2016

Pull Request for Improvements.

Summary of Changes

This PR adds state tasks dropdown actions to tags component.

Before PR

image

After PR

image

Testing Instructions

  1. Use latest staging and apply patch
  2. Test the new dropdown menu in all possible tags states (published, unpublished, archived and trash)
avatar andrepereiradasilva andrepereiradasilva - change - 23 Apr 2016
Status New Pending
avatar andrepereiradasilva andrepereiradasilva - open - 23 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 23 Apr 2016
Category Components UI/UX
avatar brianteeman
brianteeman - comment - 23 Apr 2016

This isnt quite the same as com_content
In com_content if you go to a trashed icon it always shows archive/trash
Here it shows archive/publish


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10065.

avatar brianteeman
brianteeman - comment - 23 Apr 2016

This isnt quite the same as com_content
In com_content if you go to a trashed icon it always shows archive/trash
Here it shows archive/publish


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10065.

avatar brianteeman
brianteeman - comment - 23 Apr 2016

I see now that this is what you are doing in #10062 I'm not sure about this change


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10065.

avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Apr 2016

@brianteeman that's the bug in com_content. How do we trash a trashed item? trash 2x?

avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Apr 2016

In com_content if you go to a trashed icon it always shows archive/trash

No it won't, check that in com_content if you filter the - Select Status - by "Trashed" you will see the correct options in the trashed items: "Archive" and "Publish".

The problem is when you filter the - Select Status - by "All".

As said before, and explained in #10062, it's a bug in the current implementation of the state dropdows.

The dropdown is currently generated based on the - Select Status - filter state and not on the item state, as it should.
This creates some problems, for instance, if you select, in the state filter, "All", an item in a trashed state has a trash option ... similiar, an article in archived state has the archive option.

avatar brianteeman
brianteeman - comment - 24 Apr 2016

Yes thats definitely a bug


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10065.

avatar brianteeman brianteeman - test_item - 24 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Apr 2016

I have tested this item :white_check_mark: successfully on 71027c2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10065.

avatar ghazal ghazal - test_item - 25 Apr 2016 - Tested successfully
avatar ghazal
ghazal - comment - 25 Apr 2016

I have tested this item :white_check_mark: successfully on 71027c2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10065.

avatar brianteeman brianteeman - change - 25 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 25 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10065.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 25 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 2 May 2016
Labels Added: ?
avatar rdeutz rdeutz - merge - 2 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 2 May 2016
avatar rdeutz rdeutz - change - 2 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-02 06:37:33
Closed_By rdeutz
avatar rdeutz rdeutz - close - 2 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment