[#10059] - Archived articles view year selection hardcoded
- Fixed in Code Base
- 23 Apr 2016
- Medium
- Build: staging
- # 10059
- Diff
- alikon:patch-61
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #6754 .
Summary of Changes
Added a getYears() function to retrive only archived content items years
to the archived model class
and the call in the view class
Testing Instructions
from backend set the state of some articles to archived (choose from different created year)
you should notice in the frontend that
Archieved articles view year selection must cointain only the archived year and not
the hardcode (now - 10 year)
see #6754 for more infoe
Comments
should be done better using ajax for dynamically select the relative months based on the selectecd year ....
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End |
| Rel_Number | 0 | ⇒ | 6754 |
| Relation Type | ⇒ | Pull Request for |
Is this related to https://issues.joomla.org/tracker/joomla-cms/9963 where a change in /components/com_content/router.php prevents the hyperlinks (displayed in the Archived Articles page) acting correctly ?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10059.
No - not related at all
On 23 April 2016 at 11:36, Kevin Griffiths notifications@github.com wrote:
Is this related to https://issues.joomla.org/tracker/joomla-cms/9963
where a change in /components/com_content/router.php prevents thehyperlinks (displayed in the Archived Articles page) acting correctly ?
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10059
https://issues.joomla.org/tracker/joomla-cms/10059.—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10059 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman can you re-test?
I have tested this item 
successfully on 853a848
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10059.
Can you take a look at the codestyle issues reported by travis please
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10059.
| Title |
|
||||||
| Title |
|
||||||
...this time travis seems a friend of mine....
I have tested this item successfully on 853a848
Nice catch - Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10059.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-23 18:27:23 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Awesome stuff
Just a small bug with checking the end publishing date
Create an article with a start publishing date in 1999 and end publishing date in 2000
Set that article to archived
The filter will show 1999 as a valid year but the article wont display because it has expired
So I guess your code that generates the years needs to check not only for archived but also for end publishing date
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10059.