[#10026] - Save an active tab state inside nested tab sets
- Fixed in Code Base
- 27 Jul 2016
- Medium
- Build: staging
- # 10026
- Diff
- shanginn:patch-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
I have modified this code to keep tracks of all active tabs, when there is nested tabs present.
For example, if you making changes in some category and you navigate to the Rules tab there will be another tab set inside with Groups. With previous code only last clicked tab is saved to local storage.
So if you clicked Rules tab in the local storage will be "#rules", but when you click some Group this "#rules" will be overtighten by, for example, "#permission-1" and next time you reload the page your Rules tab will not be active.
With this code all active tabs will be tracked and saved to local storage.
Testing Instructions
Create a category in Articles manager, click Rules, click Public. Reload the page and there you have it: Rules and Public both open.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript |
I think he means permissions
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10026.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10026.
I have tested this item
Just followed the steps given and it tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10026.
I have tested this item
Tested successfully with Joomla Version: Joomla! 3.6.0-rc Release Candidate [ Noether ] 28-June-2016 20:34 GMT
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10026.
gunjanpatel
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
@killoltailored, yeah, I meant permissions.
@roland-d, I'm sorry, but I don't know where I can find conflicts. It's my first pull-request experience.
It says
This branch has conflicts that must be resolved
Only those with write access to this repository can merge pull requests.
If you could, provide some more information please, it'll be my pleasure to contribute.
I'm sorry, but I don't know where I can find conflicts.
No problem, let me try to help you. If you are familiar with GIT, the easiest way to find out the conflicts is to merge the staging branch into your patch-1 branch.
If you are not familiar with GIT, the easiest is to make a new pull request and reference this one.
Let me know if you need any further help.
Thank you for the reply. But I don't really know, if I did it right. please, correct me, if there is something wrong.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-27 09:30:36 |
| Closed_By | ⇒ | wilsonge |
| Category | JavaScript | ⇒ |
| Labels |
Removed:
?
|
||
About third party, any code using localStorage.getItem('tab-href') is now broken !
More over, now if i need to know the active tab, i need first to JSON.parse then take the last value .pop().
active-tabs hold the history of clicked tabs, so if we take for example the content components, if you click 20 times tabs then reload, script will show/hide step by step tabs... what about performance ?
Please open a new bug report with all needed information. Commenting on a closed / merged PR get missed fast. Thanks
Please provide more information regarding where can find "RULES" option in Article Manager
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10026.