Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10025] - [com_search] Implement searchtools

? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
21 Apr 2016

Summary of Changes

This PR, like already done in most views across Joomla admin panel, implements searchtools in com_search searches view.

Before PR

image

After PR

image

Testing Instructions

  1. Apply this patch in latest staging
  2. Go to Components -> Search
  3. Go to Options and enable gathering statistics
  4. Go to the frontend index.php?option=com_search&view=search URI and do some searches.
  5. Go again to Components -> Search, you'll see some search results
  6. Apply this patch
  7. Go again to Components -> Search you'll see the new visual
  8. Test if search, filters, ordering and page limit (aka searchtools) are working properly. Test also the hide/show search results button.
avatar andrepereiradasilva andrepereiradasilva - open - 21 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 21 Apr 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 21 Apr 2016
Labels
Easy No ⇒ Yes
avatar brianteeman brianteeman - change - 21 Apr 2016
Category ⇒ Components Language & Strings UI/UX
avatar brianteeman brianteeman - test_item - 21 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Apr 2016

I have tested this item :white_check_mark: successfully on 3d51086

It works but I have no idea at all why we have the show/hide search results button and even if there is a good reason (db performance) the text is wrong. Its a frequency count(hits) not a result

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10025.

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Apr 2016

It works but I have no idea at all why we have the show/hide search results button and even if there is a good reason (db performance) the text is wrong. Its a frequency count(hits) not a result

I understand, but it was already like that i didn't change it. That's for another PR, i guess.

avatar grhcj grhcj - test_item - 22 Apr 2016 - Tested successfully
avatar grhcj
grhcj - comment - 22 Apr 2016

I have tested this item :white_check_mark: successfully on 3d51086

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10025.

avatar brianteeman brianteeman - change - 22 Apr 2016
Status Pending ⇒ Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 22 Apr 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10025.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 92a6a7c - 22 Apr 16
avatar rdeutz rdeutz - merge - 22 Apr 2016
avatar rdeutz rdeutz - close - 22 Apr 2016
avatar rdeutz rdeutz - change - 22 Apr 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-22 19:26:40
Closed_By ⇒ rdeutz
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 22 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment