Feeling Lucky
[#363] - xml code-style
- Fixed in Code Base
- 31 Aug 2017
- Medium
- Build: master
- # 363
- Diff
- brianteeman:codestyle
- Success continuous-integration/drone/pr the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
update the xml to follow the joomla codestyle for xml files
@Quy can you review please
| Milestone |
Added: Weblinks 3.7.0 |
||
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-31 17:55:59 |
| Closed_By | ⇒ | zero-24 |
zero-24
- comment
- 31 Aug 2017
Thanks @brianteeman
brianteeman
- comment
- 31 Aug 2017
thanks
Quy
- comment
- 31 Aug 2017
Sorry to be late. Found some issues:
https://github.com/brianteeman/weblinks/blob/f290ad3e234998d3695dee48dafe73b90feed354/src/components/com_weblinks/views/category/tmpl/default.xml#L15
https://github.com/brianteeman/weblinks/blob/f290ad3e234998d3695dee48dafe73b90feed354/src/components/com_weblinks/views/category/tmpl/default.xml#L212
brianteeman
- comment
- 31 Aug 2017
it has been merged :(
so please create a PR
zero-24
- comment
- 31 Aug 2017
I have fixed them now with direct commits. thanks.
most things looks good to me. I have left some inline comments.