[#362] - Make it joomla 4 compatible
- Fixed in Code Base
- 16 Aug 2019
- Medium
- Build: master
- # 362
- Diff
- Digital-Peak:j4-compat
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Makes web links installable and working on the current Joomla 4 branch. This fixes only the PHP errors. The layouts are not touched as we are still working on a proper BC solution joomla/joomla-cms#17190.
yvesh
- | Milestone |
Added: Weblinks 3.7.1 |
||
zero-24
- 
Added the parent check call. All should be fine now.
I would like to have a not namespaced version for Joomla 4 which is working and a namespaced version for Joomla 3.9 for testing. So we need this one here.
How is this PR related to the 4.0-dev branch?
This PR seems to only perform the minimally neccessary changes for it to work with Joomla 4.x
The Branch on the other hand is in a really strange state of something in between 3.x and 4.x style.
All of the Administrator stuff is namespaced and using 4.x style, while the component/frontend part seems to be untouched and still stuck in 3.x
Yet neither of the two seems to have adjusted to moving the dispatcher into it's own namespace as well.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-16 13:52:56 |
| Closed_By | ⇒ | wilsonge |
We need to make sure that
parent::checkis called inWeblinksTableso that we can have that plugin event properly triggered in the parent method