enhancement Failure

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
24 Mar 2017

Pull Request for Issue #290

Summary of Changes

Move language files for the search plugin into the plugin distribution file. This makes all the plugins consistent in not putting language files into administrator/language.

Testing Instructions

  • Install 3.7.0b2
  • apply this patch
  • confirm the language files in the plugins folder

Expected result

the language files in the plugins folder

Actual result

the language files are not in the plugins folder

Documentation Changes Required

None

avatar zero-24 zero-24 - open - 24 Mar 2017
avatar zero-24 zero-24 - change - 24 Mar 2017
Milestone Added: Weblinks 3.7.0
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Mar 2017

Install 3.7.0b2

"3.7.0b2" is the latest staging (=weblinks.master.zip)?

avatar zero-24
zero-24 - comment - 24 Mar 2017

3.7.0b2 means the CMS not the weblinks ;)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Mar 2017

i have 3.7.0-rc1 (neweset nightly build) installed. Can i test on this?

avatar infograf768
infograf768 - comment - 24 Mar 2017

I have no problem with this if we keep putting the lang files in the admin part in the CMS.
If any change has been done for weblinks where lang files are not put into the admin or site main languages folders, please revert!

avatar zero-24
zero-24 - comment - 24 Mar 2017

Yes @franz-wohlkoenig

Yes @infograf768 that is the plan.

avatar infograf768
infograf768 - comment - 24 Mar 2017

tks for reply.

avatar zero-24
zero-24 - comment - 24 Mar 2017

This is just to clean up the repo here ;)

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 24 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Mar 2017

I have tested this item successfully on 64d246f

After PR are Lang.-Files in Folder:
bildschirmfoto 2017-03-24 um 18 47 33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/334.
avatar yvesh yvesh - reference | 300460a - 25 Mar 17
avatar yvesh yvesh - merge - 25 Mar 2017
avatar yvesh yvesh - change - 25 Mar 2017
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-25 11:25:32
Closed_By yvesh
Labels Added: enhancement
avatar yvesh yvesh - close - 25 Mar 2017
avatar yvesh yvesh - merge - 25 Mar 2017
avatar yvesh yvesh - close - 25 Mar 2017
avatar yvesh
yvesh - comment - 25 Mar 2017

Thank you @zero-24

avatar zero-24 zero-24 - head_ref_deleted - 25 Mar 2017
avatar zero-24
zero-24 - comment - 25 Mar 2017

Thanks @yvesh

Add a Comment

Login with GitHub to post a comment