enhancement Failure

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
24 Mar 2017

Pull Request for Issue #288 (redo because of merge conflicts)

Summary of Changes

Move web links statistics shown on the admin control panel from Joomla core to a system plugin in the web links package.

Testing Instructions

  • install 3.7.0 (as this is a new plugin event)
  • Create at least one published web link.
  • apply this pr
  • discover the new plugin
  • install ist
  • Enable the system plugin.
  • You should now have an entry about the weblinks count.

Expected result

You should now have an entry about the weblinks count.

Actual result

You don't see any count in the CMS it selfe (in 3.7.0b)

Documentation Changes Required

None.

avatar zero-24 zero-24 - open - 24 Mar 2017
avatar zero-24 zero-24 - change - 24 Mar 2017
Milestone Added: Weblinks 3.7.0
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Mar 2017

install 3.7.0 (as this is a new plugin event)

means installing weblinks-master.zip?

avatar zero-24
zero-24 - comment - 24 Mar 2017

Last cms version ;)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Mar 2017

installed weblinks-master.zip on 3.7.0-rc1:
bildschirmfoto 2017-03-24 um 18 14 52

avatar zero-24
zero-24 - comment - 24 Mar 2017

You can not install weblinks master you need to use the last published version of weblinks ;)

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 24 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Mar 2017

I have tested this item successfully on efc3e39

After PR in Module "Statistics" Weblink + Count is shown:
bildschirmfoto 2017-03-24 um 18 41 08

After installing weblink-pkg. Lang.String is missed:
bildschirmfoto 2017-03-24 um 18 37 03


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/333.
avatar zero-24 zero-24 - change - 25 Mar 2017
Labels Added: enhancement
avatar zero-24
zero-24 - comment - 25 Mar 2017

I have just fixed a tab to spaces error.

@franz-wohlkoenig this is expected behavior as the XML file is generated on the time @yvesh release a new version.

avatar astridx
astridx - comment - 25 Mar 2017

I tested this patch successfully

I created a web link.
I created a menu item and clicked the weblink one time and I saw one hit.
I created an admin module of the type statistic. I see no entry for this in the module because the core patch is merged.
After that I copied the system plugin from this patch into the system plugin folder of my installation, discovered it and activated it.
After that I saw an entry for my weblink in the statistic module
avatar astridx astridx - reference | 4c23724 - 25 Mar 17
avatar astridx astridx - merge - 25 Mar 2017
avatar astridx astridx - close - 25 Mar 2017
avatar astridx astridx - change - 25 Mar 2017
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-25 14:01:53
Closed_By astridx
avatar astridx astridx - close - 25 Mar 2017
avatar astridx astridx - merge - 25 Mar 2017
avatar zero-24 zero-24 - head_ref_deleted - 25 Mar 2017
avatar zero-24
zero-24 - comment - 25 Mar 2017

Thanks @astridx

Add a Comment

Login with GitHub to post a comment