Feeling Lucky
[#318] - Review XML CS for the XML files in the component
- Closed
- 22 Mar 2017
- Medium
- Build: master
- # 318
- Diff
- zero-24:xmlcs
- Success continuous-integration/drone/pr the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Review XML CS for the XML files in the component
Testing Instructions
Confirm the admin & Frontend component options still work (for the frontend it is the submit form)
Expected result
Use cs
Actual result
Use not cs
Documentation Changes Required
None.
| Milestone |
Added: 3.6.0 |
||
| Milestone |
Added: Weblinks 3.7.0 |
||
| Milestone |
Removed: 3.6.0 |
||
yvesh
- comment
- 15 Mar 2017
@zero-24 isn't there a tab missing before every greater than? :)
https://developer.joomla.org/coding-standards/xml.html
<field
name="count_clicks"
<!--...-->
>
vs
<field
name="count_clicks"
<!--...-->
>
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-22 09:51:28 |
| Closed_By | ⇒ | yvesh |
I tested this patch succesful.
I applied the patch and created a weblink and changed some configuration. After that I created a menu item and the view in the frontend was correct.
Then I realised, that there are conflics. I was suprised, because it was possible to apply this patch with patch tester. I solved this conflics, I cheated in the patch tester code.
Because of the conflics I am not sure if I can merge this.