Failure

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
25 Feb 2017

Summary of Changes

Add basic custom fields support

Testing Instructions

Apply this patch on a 3.7 version

Expected result

Confirm you can add an fill the custom fields, there is no rendering done in the frontend yet

Actual result

No custom fields support

Documentation Changes Required

None.

95bd6c9 25 Feb 2017 avatar zero-24 cs
avatar zero-24 zero-24 - open - 25 Feb 2017
avatar zero-24 zero-24 - change - 25 Feb 2017
Title
[3.7] Add basic custom fields support
[RFC] [3.7] Add basic custom fields support
avatar zero-24 zero-24 - change - 25 Feb 2017
Title
[3.7] Add basic custom fields support
[RFC] [3.7] Add basic custom fields support
avatar zero-24 zero-24 - edited - 25 Feb 2017
avatar yvesh yvesh - change - 25 Feb 2017
Milestone Added: Weblinks 3.7.0
avatar astridx
astridx - comment - 12 Mar 2017

I tested this succeful a few days ago. It was possible to add and edit custom fields in the backend.
But this fields are not shown in the frontend. Should we merge this stand and add the frondend support in an separat pr?

avatar zero-24
zero-24 - comment - 12 Mar 2017

I would let this unmerged until there is a final decision if we need this in weblinks. As it makes no sense to have a backed option that cant be used in the frontend. ;)

avatar zero-24 zero-24 - change - 22 Apr 2017
Milestone Removed: Weblinks 3.7.0
avatar zero-24 zero-24 - change - 22 Apr 2017
Milestone Added: Weblinks 3.7.1
avatar zero-24 zero-24 - change - 22 Apr 2017
Milestone Added: Weblinks 3.7.1
avatar zero-24 zero-24 - change - 22 Apr 2017
Milestone Removed: Weblinks 3.7.0
avatar hakanara
hakanara - comment - 13 Sep 2017

I have some menu links like: index.php?option=com_weblinks&view=category&id=71
I would like to use fields in these menu items. I think there is no progress so far in adding fields for weblinks. Am I right? Are you planing to do so?

avatar yvesh
yvesh - comment - 13 Sep 2017

@hakanara yes it's planned for Weblinks 3.7 - the thing is we are missing testers here and there is a merge conflict in this patch.

@zero-24 can you remove the merge conflict? Going to test it than in the next days

avatar zero-24
zero-24 - comment - 13 Sep 2017

@zero-24 can you remove the merge conflict? Going to test it than in the next days

done.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 14 Sep 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Sep 2017

I have tested this item ? unsuccessfully on 8b9ab39

Install PR, click on Weblink-Options:
bildschirmfoto 2017-09-14 um 07 12 35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/317.
avatar hakanara
hakanara - comment - 17 Sep 2017

Is there anything that I can do now, like testing something?

avatar astridx
astridx - comment - 17 Sep 2017

@hakanara That would be great if you would test.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Sep 2017

@astridx will test tomorrow.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 18 Sep 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Sep 2017

I have tested this item successfully on e69347e

I can add and fill Custom Fields, no Rendering in the Frontend.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/317.

avatar astridx
astridx - comment - 18 Sep 2017

@franz-wohlkoenig Thank you.

@ALL Does anyone have anything against it when I merge that?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Sep 2017

@astridx is a Frontend-Rendering coming?

avatar astridx
astridx - comment - 18 Sep 2017

@franz-wohlkoenig
Yes frontend rendering will work, when we have the single view from this pr #349

avatar hakanara
hakanara - comment - 18 Sep 2017

Thank you very much all. I will be able to test it soon. Before that.can I ask you if the frontend rendering will be available only for the single item? I need it for weblinks category view as well.

Kind regards.

avatar hakanara
hakanara - comment - 30 Sep 2017

I wanted to test this, I downloaded and installed Joomla 3.8.1-rc2-dev. I have downloaded and installed Joomla patch tester. Then I have retrieved the 4 pull requests. But when I apply patch for this item, I get this error:
The file marked for modification does not exist: src/administrator/components/com_weblinks/access.xml

Why is this and what can I do test this patch?

And also, I have asked a question above which remained unanswered. Will the fields functionality be working for new weblinks for the links like: index.php?option=com_weblinks&view=category&id=71
I need frontend fields rendering for the weblinks category page as well.

Kind regards.

avatar astridx
astridx - comment - 30 Sep 2017

Hi @hakanara
thank you very much.

The file marked for modification does not exist: src/administrator/components/com_weblinks/access.xml
Why is this and what can I do test this patch?

You also have to install weblinks as it is not integrated in Joomla! any more.

Will the fields functionality be working for new weblinks for the links like: index.php?option=com_weblinks&view=category&id=71
I need frontend fields rendering for the weblinks category page as well.

I'm not 100% sure, but I mean yes. A test will show you.

Note, the single view is not part of this PR. You find this in this PR: #349

avatar hakanara
hakanara - comment - 30 Sep 2017

Hi @astridx I have also installed weblinks pkg-weblinks-3.6.0 from Joomla offical extensions on top of the installation that I have stated above but the issue still persists with the same error.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Sep 2017

I guess you have to install pkg-weblinks-3.7.0-beta1.zip

avatar hakanara
hakanara - comment - 30 Sep 2017

Danke @franz-wohlkoenig I also installed that and I still get the same error. Very strange. Is there any other way to upload the patch and see if it works or not?

avatar astridx
astridx - comment - 30 Sep 2017

Is there any other way to upload the patch and see if it works or not?

You can apply the patch via git as explained here:
https://github.com/joomla-extensions/weblinks
But then you have to build the installation package from the data in the src directory or use the tests to create this.

Do you see a file with the name access.xml in your folder JOOMLA/administrator/components/com_weblinks/access.xml ?

avatar hakanara
hakanara - comment - 30 Sep 2017

The access.xml file exists in that directory:
JOOMLA/administrator/components/com_weblinks/access.xml

But theere is no folder called JOOMLA/src/administrator/components/com_weblinks/access.xml

I will see if I can create an installation package from those files there. Thank you very much.

avatar astridx
astridx - comment - 30 Sep 2017

But theere is no folder called JOOMLA/src/administrator/components/com_weblinks/access.xml

I think this is the file that patch tester want to take out of the weblinks repo for overriding your joomla weblink installation.

avatar hakanara
hakanara - comment - 30 Sep 2017

OK, I have downloaded the weblinks-master.zip file, extracted that, copied all the src directory to the root of my Joomla directory. And finally I managed to apply the patch/es.

I don't want to mislead anyone but after the aaplication, I didn't see any "fields" menu link under weblinks menü in administration. Also I clicked on "new" to see if there will be any fields tab when I create a new single web link or a web link category.

If you need further assistance, I will be available for testing the issue. Thank you very much for all the contributers for their time and efforts

avatar astridx astridx - change - 3 Nov 2017
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-03 20:45:36
Closed_By astridx
avatar astridx astridx - close - 3 Nov 2017
avatar astridx astridx - merge - 3 Nov 2017
avatar astridx astridx - reference | 50ee6f5 - 3 Nov 17
avatar astridx astridx - merge - 3 Nov 2017
avatar astridx astridx - close - 3 Nov 2017
avatar zero-24 zero-24 - head_ref_deleted - 4 Nov 2017
avatar hakanara
hakanara - comment - 11 Dec 2017

Hello. Is there any progress for adding the custom fields for weblinks?

avatar astridx
astridx - comment - 11 Dec 2017

Hello. Is there any progress for adding the custom fields for weblinks?

Yes, this PR is merged. But we do not have a release up to now.
If you like you can install web links for testing with the zip file from this comment: #377 (comment)
If there is more interest, maybe there will be a new release sooner.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Dec 2017

I'm interested.

Add a Comment

Login with GitHub to post a comment