@mbabker i hope you can have a look here. On testing i notice that this script.php never gets executed.

I have just try to add a coding issue that should throw an error e.g. missing ; or missing <?php but all times i get Installing component was successful. i don't know how to find the issue and fix it? Sorry.

From the way I have one of my components structured, it looks like the script.php file is in the wrong place. Try moving it to src/com_weblinks/script.php and building fresh packages.

Thanks @mbabker ! It fails now as expected. Now i will try to implement $db->getTableColumns()

I hope i get is well now. I have update the download package now: pkg_weblinks341

how to test

• make sure you can install the package successful without errors. (by using the link via install from ULR or download to use and upload and install)
• do a code review on github.

@zero-24 I sent you a PR for this PR, see zero-24#1

Thanks @bembelimen just merged

Now this should also fix #31 Thanks @Re:Later (on the german forum: http://forum.joomla.de/index.php/Thread/256-Fehler-im-Backend-Komponente-Weblinks/?postID=1815#post1815)

The package is updated now and should bring weblinks back to work after upgrading from 2.5.28 to 3.4.1. pkg_weblinks341

Please report back your findings and test results.

after updating from 2.5.28 to 3.4.1 the pkg_weblinks341 was the solution to fix the problems in my weblinks. i installed it with url and in 5 sec all things work as expected.

have fun
Hermann

It works now! Thanks to @mbabker! :-)

The package is updated again and now match the current state here with the suggestions by @mbabker and @Bakual

The package should bring weblinks back to work after upgrading from 2.5.28 to 3.4.1. pkg_weblinks341

Please report back your findings and test results.

we have 16 downloads from the last version without any more issue reports with the patch. The only one is fixed here: #33 so i guess we can move it to RTC.

We are now to a total count of downloads of 86 without any more issues reported.

installed successfully and functional on a 3.4.1 site,
upgraded from 2.5x that was using weblinks

Thanks for your test @marcodings ! Today we have a total download count of 157 for the final download.

I am also having problems with this. I have downloaded pkg_weblinks341.zip and was going to install this through the extension manager after uninstalling the previous version. However, I have 3 different extensions already installed and not sure which one/s to uninstall. This was a site that was upgraded from version 2.x

You don't uninstall the old version. You install the update over the existing version. That should take care of everything.

Trying to install the update over the current version results in these to error messages:

"Warning
Duplicate column name 'version' SQL=ALTER TABLE nux37_weblinks ADD COLUMN version int(10) unsigned NOT NULL DEFAULT '1';

Package Update: There was an error installing an extension: com_weblinks.zip"

Error
Error installing package

Please open a new issue so this can be tackled. This one is a closed one.