Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
1 Apr 2015

Please don't merge before this issue is fixed: #25

befor this Change the update is only stored to the database and not displyed to the users.
But we have the issue with the install of com_weblinks (#25) so i don't think we should fix that bevor we show this broken update to all ouer users.

avatar zero-24 zero-24 - open - 1 Apr 2015
avatar zero-24
zero-24 - comment - 12 Apr 2015

If we merge now:
#30 and #33 We can release a new version and merge this here also to fix the issues with weblinks in 3.4.x Thanks :smile:

avatar wilsonge
wilsonge - comment - 18 May 2015

What's this actually solving tobias? I'm not quite clear?

avatar zero-24
zero-24 - comment - 18 May 2015

@wilsonge without this patch the internal updater will never match the update :smile:

avatar zero-24
zero-24 - comment - 18 May 2015

bzw. merge this if we have fix the update XML (new packeage) as all websites goes directly to this file. :smile:

avatar wilsonge
wilsonge - comment - 18 May 2015

@mbabker is there something weird with the update mechanism here then (something related to your changes in 3.4?)? because docs state that it should automatically have client with a value of 1 https://docs.joomla.org/Deploying_an_Update_Server

avatar zero-24
zero-24 - comment - 18 May 2015

@wilsonge

[..]but you will need to specify the client in an update or it will default to 1 (administrator) and then found update would not be shown because it would not match any extension. Components are automatically installed with a client of 1, which is currently the default.

But the Client is 0 / Site here. As we have a package update (pkg_weblinks not com_weblinks) :smile:

See: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/sql/updates/mysql/3.4.0-2014-09-01.sql#L2

avatar wilsonge wilsonge - reference | 918e3c5 - 18 May 15
avatar wilsonge wilsonge - merge - 18 May 2015
avatar wilsonge wilsonge - close - 18 May 2015
avatar wilsonge
wilsonge - comment - 18 May 2015

I am .... an idiot :D

avatar zero-24
zero-24 - comment - 18 May 2015

@wilsonge please revert. Now all joomlas will show the bad update!! Please release a new version bevor merge!

avatar zero-24 zero-24 - head_ref_deleted - 18 May 2015
avatar zero-24 zero-24 - change - 18 May 2015
Milestone Added: 3.4.1

Add a Comment

Login with GitHub to post a comment