Joomla! Issue Tracker - Weblinks

Download
Launch
Feeling Lucky

[#290] - Move lang files for search plugin

Failure

User tests: Successful: Unsuccessful:

avatar chrisdavenport
chrisdavenport
2 Jan 2017

Summary of Changes

Move language files for the search plugin into the plugin distribution file. This makes all the plugins consistent in not putting language files into administrator/language.

Testing Instructions

Upgrade an existing web links installation and make sure there are no web links language files in administrator/language/en-GB. Make sure language strings for the search plugin are still working.

avatar chrisdavenport chrisdavenport - open - 2 Jan 2017
avatar astridx
astridx - comment - 8 Jan 2017

I tested this successful.

  1. I applied your patch
  2. I deleted the files en-GB.plg_search_weblinks.ini and en-GB.plg_search_weblinks.sys.ini in the language admin folder. They have been already there in my case.
  3. I make sure, that the language files are already working.

I only would suggest to start the name of the class with a upper case letter.

bildschirmfoto vom 2017-01-08 11-22-50

avatar zero-24
zero-24 - comment - 8 Jan 2017

@chrisdavenport i have send you a PR: chrisdavenport#1 that reduces the code and use the Joomla API to do that stuff.

avatar chrisdavenport
chrisdavenport - comment - 14 Jan 2017

Thanks @zero-24

avatar yvesh
yvesh - comment - 13 Feb 2017

This needs fixing a bug in the build script JoRobo first. (It ignores language files in the plugin folder currently)

avatar zero-24 zero-24 - change - 13 Feb 2017
Milestone Added: Weblinks 3.7.0
avatar zero-24 zero-24 - change - 13 Feb 2017
Milestone Added: Weblinks 3.7.0
avatar zero-24
zero-24 - comment - 12 Mar 2017

@chrisdavenport please fix the merge conflicts and or allow the maintainer edits. Thanks ?

avatar zero-24
zero-24 - comment - 12 Mar 2017

This needs fixing a bug in the build script JoRobo first. (It ignores language files in the plugin folder currently)

I expect this is done already?

avatar zero-24
zero-24 - comment - 24 Mar 2017

Closing here because there is no update. I have done a new PR with the needed changes #334

avatar zero-24 zero-24 - close - 24 Mar 2017
avatar zero-24 zero-24 - close - 24 Mar 2017
avatar zero-24 zero-24 - change - 24 Mar 2017
Milestone
avatar zero-24 zero-24 - change - 24 Mar 2017
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-03-24 12:12:37
Closed_By ⇒ zero-24
avatar chrisdavenport chrisdavenport - head_ref_deleted - 3 Jun 2017

Add a Comment

Login with GitHub to post a comment