system tests / QA Failure

User tests: Successful: Unsuccessful:

avatar kshitijSharma2014
kshitijSharma2014
8 Mar 2016

I couldn't understand where to place these tests as they test the multi-lingual feature of Joomla. These tests are also integrated tests. I have used a function for which I have also done a PR here : joomla-projects/joomla-browser#105

avatar kshitijSharma2014 kshitijSharma2014 - open - 8 Mar 2016
avatar kshitijSharma2014
kshitijSharma2014 - comment - 8 Mar 2016

@javigomez Please review
Thanks :)

avatar kshitijSharma2014
kshitijSharma2014 - comment - 8 Mar 2016

To Test the PR please install multilingual Joomla. In the InstallWeblinksCest.php
replace $I->installJoomlaRemovingInstallationFolder(); with $I->installJoomlaMultilingualSite();

Thanks

avatar kshitijSharma2014
kshitijSharma2014 - comment - 10 Mar 2016

@javigomez checkes are failing here because I have created a function in joomla browser for delete menu. After it get merged, these checks might pass.

avatar yvesh
yvesh - comment - 10 Mar 2016

Can you reformat it in the correct code style? (Tabs instead of spaces etc.). Some more tips in the code.

http://joomla.github.io/coding-standards/

Thanks for your contribution :+1:

avatar kshitijSharma2014
kshitijSharma2014 - comment - 11 Mar 2016

@yves please review it
thanks :)

avatar javigomez javigomez - assigned - 23 Jun 16
avatar yvesh
yvesh - comment - 1 Aug 2016

@kshitijSharma2014 What's the status on this? Can you please give an update in the next days? Else i will close it for now. Thank you!

avatar kshitijSharma2014
kshitijSharma2014 - comment - 1 Aug 2016

@yvesh I am closing it right now. I will re-do a new PR with these changes. :)

Add a Comment

Login with GitHub to post a comment