[#195] - Phone Environment Testing works (Install & Administrator)
- Closed
- 1 Aug 2016
- Medium
- Build: master
- # 195
- Diff
- gauravmittal1995:PhoneTestFix
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
The Install and Administrator Acceptance Tests work with phone environment
Depends on: joomla-projects/joomla-browser#104
@gauravmittal1995 With your changes, tests are failing on Travis
https://travis-ci.org/joomla-extensions/weblinks/jobs/114619924#L1956 See this
Can you think of a reason why it would fail?
@puneet0191 Hi, It uses a new function in Joomla Browser which i have used.
the PR is still open in joomla Browser for it.
Good 
Prepare your Proposal, we will talk soon.
@gauravmittal1995 Can you adjust the code style to the joomla one? http://joomla.github.io/coding-standards/ (Tab is 4 spaces btw). Thanks for your contribution!
javigomez
-
@gauravmittal1995 This PR has merge conflicts and need some improvements. Closing for now. If you want you can do a clean pull request again! Thank you for your contribution!
@puneet0191 Hi, Can you please review this and let me know if i am proceeding in the correct direction?