Feeling Lucky
[#81] - varchar too long for postgresql
- Closed
- 9 May 2015
- Medium
- Build: master
- # 81
- Diff
- alikon:patch-2
User tests: Successful: Unsuccessful:
i've expereinced when fetch data
when some pr have title > 100 and / or body > 5000
guess same fix on pull_url ?
cause
title character varying(100) NOT NULL,
description character varying(5000) NOT NULL DEFAULT ''::character varying,
pull_url character varying(255) NOT NULL,
mbabker
- comment
- 9 May 2015
I ended up lengthening the title column and truncating the description. If there are people putting a 200+ character title/summary into the tracker, they're doing something wrong at this point.
Thanks for raising the issue!
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-09 17:15:42 |
| Closed_By | ⇒ | mbabker |
alikon
- comment
- 10 May 2015
Thanks for the fix hope now more people get involved on testing PR on Postgresql too
As we're only showing the description in a tooltip now (which IIRC is truncated to 50 characters), we should be able to shorten the field in the database and truncate the description on insert.
For the title, I actually think I'd prefer lengthening the field in the database versus truncating it.