Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
17 Feb 2015

This PR does two things. Firstly it stops using the deprecated rate endpoint (https://developer.github.com/v3/rate_limit/#deprecation-notice) and just checks if the value is explicitly 0 - removing an else statement and thus reducing the complexity of the code.

If you are code reviewing then it may help to look at the version with tabbing changes excluded (https://github.com/joomla-extensions/patchtester/pull/64/files?w=1)

Untested as currently don't have the dataspeed on my mobile to actually download all the PR's :P will try in the office tomorrow morning

avatar wilsonge wilsonge - open - 17 Feb 2015
avatar wilsonge wilsonge - close - 22 Feb 2015
avatar wilsonge wilsonge - change - 22 Feb 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-02-22 21:27:52
avatar wilsonge wilsonge - close - 22 Feb 2015
avatar mbabker mbabker - reference | ee8f6be - 22 Feb 15
avatar wilsonge wilsonge - head_ref_deleted - 23 Feb 2015

Add a Comment

Login with GitHub to post a comment