[#58] - Proposal fix for: Don't throw an exception when you can't connect to server Ref:#57
- Closed
- 9 May 2015
- Medium
- Build: master
- # 58
- Diff
- zero-24:patch-1
User tests: Successful: Unsuccessful:
see: #57
@wilsonge @mbabker can you have a look into it?
I'm not 100% sure if we can simple add here https://github.com/zero-24/patchtester/blob/patch-1/administrator/components/com_patchtester/PatchTester/Helper.php#L29 one param and / or how this function is called.
What this should do
- User enter the PW/Username
- We try to connect github and fail
- We create a github objekt without PW / Username (maybe we need to add the token here too?)
- We try to connect github
- If it fail we have throw a RuntimeException
- if it is the first connect to github fails we send the message 'Please enter User namen' and 'can't connect to github' as messages.
So the only open question is should we also disable the token with "false" or not?
As the token is a alternative login option this is also added now.
Now we have a better var name: $useUserPw
With all the restructuring, this shouldn't be an issue anymore. We now throw errors if the credentials are bad and we aren't fetching live data on each request, so at this point I think we're good to go.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-09 17:04:40 |
| Closed_By | ⇒ | mbabker |
The default issue is handled now thanks @wilsonge
So the only open question is should we also disable the token with "false" or not?