avatar sandramay0905
sandramay0905
18 Apr 2021

Steps to reproduce the issue

As title say:

Bildschirmfoto 2021-04-18 um 09 38 20

Expected result

Download of all pull requests.

System information (as much as possible)

image

avatar sandramay0905 sandramay0905 - open - 18 Apr 2021
avatar sandramay0905
sandramay0905 - comment - 21 Apr 2021

Am i the only one having this problem?

Would be sad cause i can't test anymore as prebuilt packages can't be downloaded if they are to old.

avatar sandramay0905 sandramay0905 - change - 24 Apr 2021
Title
3.0: Fetch data stops on 5th page
Fetch data stops on 5th page
avatar sandramay0905 sandramay0905 - edited - 24 Apr 2021
avatar sandramay0905
sandramay0905 - comment - 24 Apr 2021

Changed the title as same happen using v4 on Joomla4:

image

avatar roland-d
roland-d - comment - 27 Apr 2021

@sandramay0905 For some reason I do not get emails from the patchtester repository. Now I am not aware of any specific issues. When you load the list of patches from Github, does that process complete normally?

avatar sandramay0905
sandramay0905 - comment - 28 Apr 2021

does that process complete normally

It stops much earlier than before, only a part (the first five pages) of the pr are loaded.

After click on Fetch Data

  1. a modal show Processing page 1 of Github Data, no page 2 or more,
  2. then a modal show Successfully retrieved pull requests All data has been retrieved. Please close this modal window to refresh the page.

It works as expected on your side?

avatar roland-d
roland-d - comment - 28 Apr 2021

@sandramay0905 I finally had a chance to test it, but I can see what you see as well. I get a maximum of 5 pages of data. After some debugging I found the problem as well. The word Link has been changed to link.

If you want to fix this for your local installation now, you can do the following:

  • Open the file administrator/components/com_patchtester/PatchTester/Model/PullsModel.php
  • Go to line 538 and change Link to link
  • Go to line 540 and change Link to link
  • Save the file
  • Fetch the pull requests

Let me know if that works for you.

avatar sandramay0905
sandramay0905 - comment - 29 Apr 2021

Can you give me please more information about the lines? I'm working on a site installed by launch.joomla.org and there are no linenumbers shown. Searching for "Link" gave 7 results so i don't know which are the 2 correct to change:

image

avatar roland-d
roland-d - comment - 29 Apr 2021

@sandramay0905 Sure.

These 2 lines is what you look for, they are close to each other:

if (isset($pullsResponse->headers['Link']))
$linkHeader = $pullsResponse->headers['Link'];
avatar sandramay0905 sandramay0905 - change - 29 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-29 07:02:37
Closed_By sandramay0905
avatar sandramay0905 sandramay0905 - close - 29 Apr 2021
avatar sandramay0905
sandramay0905 - comment - 29 Apr 2021

Thanks for help, @roland-d. Patchtester works now as expected, closing issue.

avatar sandramay0905
sandramay0905 - comment - 2 May 2021

@roland-d Is there a timeline for a next release of patchtester? I install every day a new j4 using launch.joomla.org and do the fix too. No work but maybe a new release is coming?

avatar roland-d
roland-d - comment - 2 May 2021

@sandramay0905 The new release is out now.

avatar sandramay0905
sandramay0905 - comment - 2 May 2021

Thank you!

Add a Comment

Login with GitHub to post a comment