[#313] - Adapt CSS classes for badges to BS5
- Fixed in Code Base
- 3 Mar 2021
- Medium
- Build: master
- # 313
- Diff
- richard67:master-fix-badges-for-bs5
User tests: Successful: Unsuccessful:
Pull Request for Issue #311 .
Summary of Changes
Adapt to J4's change to BS5 for the badges: Use classes bg-... as suggested by @ceford , thanks for reporting and suggesting.
Other glitches from the BS5 change I haven't seen yet.
Testing Instructions
Install Patchtester 4 on a current 4.0-dev branch or latest 4.0 nightly build or the last beta, which all have already the change to BS5 included.
Fetch the pull requests and apply one patch to see the different colours.
Result:
Apply the changes from this PR and refresh the page,
Result:
No, we don't have the tracker for this project, we only use comment, like you did now.
I also had to apply the change manually.
All fine.
Thanks for the fix @richard67. Nearly logged another duplicate while Philip and I were onboarding GSoC students yesterday and we spotted the issue.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-03 19:50:56 |
| Closed_By | ⇒ | roland-d |
Thank you @richard67 @ceford
I had a problem applying the patch - Eclipes IDE would not show my local source file in the Patch dialog, maybe because I installed it rather than forked/cloned it. So I applied the differences by text edit. It works fine. Is there a way to mark Pass here? I normally only use the Joomla tracker.