avatar gostn
gostn
16 Oct 2020

[del]

avatar gostn gostn - open - 16 Oct 2020
avatar richard67
richard67 - comment - 16 Oct 2020

@gostn Have you noticed that the label filter is a multi-select, i.e. you can select more than one label with use of the "ctrl" key while selecting the labels?

Sure the style could be nicer, but it doesn't need to be the same as for the single-selects.

It's more comfortable to have it bigger, in my opinion.

But you are right, it doesn't look nice.

avatar richard67
richard67 - comment - 16 Oct 2020

@brianteeman Do you have an idea how we could pimp this multi-select for the labels?

Not sure if a fancy select like we have it in backend e.g. for selecting tags for articles would be the best choice, but it could be one.

But at least we should have a different look for the "Filter Label" text, which is not a selectable option but the label of that select, and the selectable options (i.e. the PR labels).

avatar brianteeman
brianteeman - comment - 16 Oct 2020

take a look at the tag filter in core views

avatar richard67
richard67 - comment - 16 Oct 2020

Ah, the list views in backend. Silly me.

avatar richard67
richard67 - comment - 16 Oct 2020

Hmm, those filters where you have to start to type something suitable before you can see anything ... I never was happy with them.

I leave it up to @roland-d to decide if those should be used for the PatchTester, too.

avatar roland-d
roland-d - comment - 16 Oct 2020

I did mention this issue in Glip, using the core style requires a complete rewrite of the view, that is going to need more time than I have available at this point. So I took this approach to have something that works but to some not look so pretty rather than have nothing at all.

In short, I will convert this to core style.

avatar roland-d roland-d - assigned - 16 Oct 20
avatar ceford
ceford - comment - 27 Oct 2020

I though this was a bug and did not realise it was a multi-select until I cam here. For me it would be prettier if it were the last filter item, after Filter Target Branch. When it wraps there is a big space down to the last filter item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/patchtester/304.
avatar richard67
richard67 - comment - 27 Oct 2020

I though this was a bug and did not realise it was a multi-select until I cam here. For me it would be prettier if it were the last filter item, after Filter Target Branch. When it wraps there is a big space down to the last filter item.

As Roland wrote in his comment above: #304 (comment)

In short, I will convert this to core style.

Then it will be same height as the other fields.

avatar gostn gostn - change - 8 Nov 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-11-08 13:16:45
Closed_By gostn
avatar gostn gostn - close - 8 Nov 2020
avatar gostn gostn - change - 9 Nov 2020
The description was changed
avatar gostn gostn - edited - 9 Nov 2020
avatar gostn gostn - change - 9 Nov 2020
Title
4.0.0.: ´Filter Label´ miss style
[del]
avatar gostn gostn - edited - 9 Nov 2020

Add a Comment

Login with GitHub to post a comment