avatar gostn
gostn
9 Oct 2020

[del]

avatar gostn gostn - open - 9 Oct 2020
avatar roland-d roland-d - change - 10 Oct 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-10-10 10:07:23
Closed_By roland-d
avatar roland-d roland-d - close - 10 Oct 2020
avatar roland-d
roland-d - comment - 10 Oct 2020

Hello,

Thank you for your report. This is not something I will implement because Patch Tester is downloading the pull requests for the Joomla repository and we do not specify a specific branch. This will be problematic as we never know which branch to pull exactly. So if I set it now to 4.0, users would not be able to get the requests for 4.1.

I understand that the 3.10 branch for example is of no use but this is the same going forward. A pull request for Joomla 5 later most likely won't work on Joomla 4 either.

By getting all the branches, the user can decide which branch to use. This is not only for the Joomla repository, you can also add custom repositories, then it is not even known which branches to use.

In this case I think we should inform users in the documentation on how to use it rather than to limit the extension.

avatar roland-d roland-d - close - 10 Oct 2020
avatar roland-d
roland-d - comment - 10 Oct 2020

How would we know which branches are J3/J3/Jx branches?

avatar roland-d
roland-d - comment - 10 Oct 2020

The Patch Tester doesn't know which branch is what, it is just text. These branches come in with the pull requests. To do what you are asking, we should put in the code 3.10-dev and 4.0-dev etc. There is no flexibility then. If there would be a 3.11 branch, it would never show up because it is not in the code.

avatar roland-d
roland-d - comment - 10 Oct 2020

No problem, thank you for your suggestions.

avatar gostn gostn - change - 9 Nov 2020
The description was changed
avatar gostn gostn - edited - 9 Nov 2020
avatar gostn gostn - change - 9 Nov 2020
Title
Fetch data for used Joomla-Version
[del]
avatar gostn gostn - edited - 9 Nov 2020

Add a Comment

Login with GitHub to post a comment