Feeling Lucky
[#284] - Joomla 4 not showing error message when patch applied and attempting to fetch
- Closed
- 25 Jul 2020
- Medium
- Build: master
- # 284
Steps to reproduce the issue
Patch Tester 4.0.0 Release Candidate 2
Install a patch
Click fetch
Expected result
Error message to tell me something
Actual result
Nothing appears to happen - left at this screen:
the Ajax response contains an error not displayed to the user
{"success":false,"message":"Cannot fetch data from GitHub while there are applied patches. Please revert those patches before continuing.","messages":null,"data":null}
roland-d
- comment
- 25 Jul 2020
This has been fixed in the upcoming release, to show the message in the modal.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-25 13:17:37 |
| Closed_By | ⇒ | PhilETaylor |
Based on the workaround that's been provided to me, the fetch data process could avoid this error occurring by checking the number of records in #_patchtester_tests first. It would then trigger an alert if the record count is >0, as that's where the data is stored for the applied patches.
If you wanted to improve the UX there you could look at: