Works when joomla/joomla-cms#28075 is applied to the CMS.

So this here should not be merged before joomla/joomla-cms#28075 into the 4.0-dev branch of the CMS.

@N6REJ This PR works, but the icon of the "Reset" button is also shown without this PR. The reason might be some magic icon to fa class mapping done in the toolbar helper for that icon. Wouldn't it be more consistent to add such mapping also for the "Fetch Data" button (icon-refresh to fas fa-sync)? If so, please make a PR for the CMS. We could use the patchtester for testing it as long as this PR here is not merged.

Without PR:

With PR:

@richard67 I looked over this today but I'm having a hard time thinking today.. There seems to be more going on then I'm seeing today. I'll get back to this in the next day to 2.

@richard67 ok, so the bigger problem is the non-use of toolbar grid like J! 4.0 uses it.

you'll notice the "icon" in both. This is due to toolbar grid not using the changes in 4.0 that were merged recently. W/o this being fixed the rest can't be fixed properly.

@N6REJ This PR works, but the icon of the "Reset" button is also shown without this PR. The reason might be some magic icon to fa class mapping done in the toolbar helper for that icon. Wouldn't it be more consistent to add such mapping also for the "Fetch Data" button (icon-refresh to fas fa-sync)? If so, please make a PR for the CMS. We could use the patchtester for testing it as long as this PR here is not merged.

You lost me here.... Not sure what needs a pr.
is joomla/joomla-cms#30053 what you mean?

Yes.

how in the world is icon- still being the default class?

Don't know for sure. But at least it should still work for 3rd party stuff.

cept it's mucking with the mapping.. there is no such thing as icon-sync

I wish I understand how he's creating the grid.. doesn't seem like it's the right way

cept it's mucking with the mapping.. there is no such thing as icon-sync

@N6REJ But there is icon-refresh to be mapped to fas fa-sync, see my comment above.

@roland-d This one here can be merged now. I've just tested and it works, the icon of the "Fetch Data" button is fixed.