Success

User tests: Successful: Unsuccessful:

avatar richard67
richard67
21 Mar 2020

Pull Request for Issue #257 .

Summary of Changes

Delete file libraries/autoload_psr4.php when applying or reverting patches on Joomla 4 and later.

Testing Instructions

Patched Patchtester package for testing this PR can be downloaded from https://test5.richard-fath.de/com_patchtester_4.0.0.beta3-dev-5.zip.

Check that applying and reverting CMS patches on Joomla 4 which move around class files or rename classes works, and after having applied such a patch neither backend nor frontend are broken in a way which could be fixed by deleting file libraries/autoload_psr4.php.

Currently available examples of such PR's:
joomla/joomla-cms#27643
joomla/joomla-cms#27648

Or maybe just check time stamp of the libraries/autoload_psr4.php, then apply a patch for J4 which requires CI system, i.e. has some scss change, and check the time stamp again, then wait a minute or more and revert the patch, and check timestamp again. Result: Time stamp changes with apply and revert.

Check that applying and reverting other CMS patches on Joomla 4 works as well as without this PR.

avatar richard67 richard67 - open - 21 Mar 2020
avatar richard67
richard67 - comment - 21 Mar 2020

Doesn't work yet. Am investigating.

avatar richard67
richard67 - comment - 21 Mar 2020

It works. I had just forgotten to apply recent js change when updating the Patchtester for my test.

Patched Patchtester package for testing can be downloaded from https://test5.richard-fath.de/com_patchtester_4.0.0.beta3-dev-5.zip.

avatar richard67 richard67 - change - 21 Mar 2020
The description was changed
avatar richard67 richard67 - edited - 21 Mar 2020
avatar richard67 richard67 - change - 21 Mar 2020
The description was changed
avatar richard67 richard67 - edited - 21 Mar 2020
avatar richard67 richard67 - change - 21 Mar 2020
The description was changed
avatar richard67 richard67 - edited - 21 Mar 2020
avatar richard67
richard67 - comment - 21 Mar 2020

Great. It works with the 2 PR's mentioned in the testing instructions.

avatar roland-d roland-d - change - 22 Mar 2020
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-22 09:10:17
Closed_By roland-d
avatar roland-d roland-d - close - 22 Mar 2020
avatar roland-d roland-d - merge - 22 Mar 2020
avatar roland-d roland-d - reference | 0dcf7c4 - 22 Mar 20
avatar roland-d roland-d - merge - 22 Mar 2020
avatar roland-d roland-d - close - 22 Mar 2020
avatar roland-d
roland-d - comment - 22 Mar 2020

@richard67 It works fine for me as well. Thank you.

avatar richard67 richard67 - head_ref_deleted - 22 Mar 2020

Add a Comment

Login with GitHub to post a comment