[#249] - [4.0] Use HttpFactory to fetch zip file from CI server
- Closed
- 21 Mar 2020
- Medium
- Build: 4.0-dev
- # 249
- Diff
- richard67:4.0-dev-use-http-factory-to-fetch-remote-files
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #233 .
Summary of Changes
See the title.
Testing Instructions
Verify that applying and reverting a PR which requires the CI server (e.g. PR joomla/joomla-cms#26845) still works without issues.
Important note: Do NOT test with a PR which changes composer dependencies like e.g. PR joomla/joomla-cms#26440. There happens a fatal error which seems to be caused by missing or removed 3rd party libraries. This is the case with and without this PR here, am investigating further.
You need the latest patchtester release https://github.com/joomla-extensions/patchtester/releases/tag/4.0.0-beta2 plus the changes from PR's merged after that release + the changes of this PR here.
You can download a patched patchtester 4.0.0-beta2 with all these changes here: https://test5.richard-fath.de/com_patchtester_4.0.0.beta3-dev-3.zip. This package also contains the change from PR #246 .
| Title |
|
||||||
| Title |
|
||||||
roland-d
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-21 08:51:51 |
| Closed_By | ⇒ | roland-d |
@roland-d Will do so, but give me a bit time.