[#247] - [4.0] Fix PHP notices
- Closed
- 9 Nov 2019
- Medium
- Build: 4.0-dev
- # 247
- Diff
- richard67:4.0-dev-fix-php-notices
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Fixes following PHP notices:
PHP Notice: Trying to get property 'insert_id' of non-object in /joomla-cms-4.0-dev/administrator/components/com_patchtester/PatchTester/Model/PullModel.php on line 599
PHP Notice: Undefined variable: revertErrored in /joomla-cms-4.0-dev/administrator/components/com_patchtester/PatchTester/Controller/ResetController.php on line 84
Testing Instructions
Code review: The mistakes are obvious:
- In ResetController.php a variable is checked also in case if never initialized.
- In PullModel.php a closing paranthesis
)is at the wrong place. The function which is called expects an integer parameter and returns an object.
Or apply and revert a PR and check the PHP error log or error display, with PHP error reporting set to maximum or development.
Now is fine.
There is something wrong with one of the 2 changes. I will make PR for the one which is ok, the other one I will investigate. Closing this in favour of the new PR's.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-09 11:51:15 |
| Closed_By | ⇒ | richard67 |
Ping @Hackwar ;-)