avatar richard67
richard67
19 Oct 2019

Steps to reproduce the issue

  1. Install a clean Joomla CMS Alpha-12.
  2. Install pachtester 4.0.0-Beta-2.
  3. Fetch Pulls.
  4. Apply a PR, eg 26614.

Expected result

PR applied.

Actual result

patchtester-4-error_1

System information (as much as possible)

Linux.

Additional comments

It seems there is a problem either with permissions or change owner.

On a clean 4.0-dev or 4.0 Alpha-12, all files belong to user "richard" and group "www-data", like it is with all files and directories of my web server. All files have permission 664, i.e. group can read and write.

After the test described above, folders and files below eg administrator folder of my Joomla Installation belonged to group "richard", which is the primary group of the user mentioned before, i.e. the group has changed. This affects all files and folder below the 1st level of folders, i.e. below administrator or below api and so on. All files below those folders have permission 644, i.e. group can read only.

avatar richard67 richard67 - open - 19 Oct 2019
avatar richard67 richard67 - change - 19 Oct 2019
The description was changed
avatar richard67 richard67 - edited - 19 Oct 2019
avatar richard67 richard67 - change - 19 Oct 2019
The description was changed
avatar richard67 richard67 - edited - 19 Oct 2019
avatar richard67
richard67 - comment - 19 Oct 2019

After having changed groups and file permissions I still get the same error, but after that groups and permissions are still correct ... I am confused now.

avatar richard67
richard67 - comment - 19 Oct 2019

richard@vmkubu01:/lamp/public_html/joomla-cms-4.0-dev$ ls -al administrator/components/com_patchtester/backups
insgesamt 16
drwxr-sr-x 3 richard www-data 4096 Okt 19 13:05 .
drwxr-sr-x 7 richard www-data 4096 Okt 19 13:03 ..
drwxr-sr-x 2 richard www-data 4096 Okt 19 13:05 26614_failed
-rw-r--r-- 1 richard www-data 68 Okt 19 13:03 readme.md
richard@vmkubu01:/lamp/public_html/joomla-cms-4.0-dev$ more administrator/components/com_patchtester/backups/readme.md
This folder contains the backup files and must be writable by PHP.
richard@vmkubu01:/lamp/public_html/joomla-cms-4.0-dev$

Hmm, the backups folder is not writable by the group. Maybe that's the problem?

Other question is why does all that stuff have the sticky bit set in permissions, ie permission "r-s" for the group?

avatar richard67
richard67 - comment - 19 Oct 2019

@mbabker Do you have any idea what could be the problem here?

avatar richard67
richard67 - comment - 19 Oct 2019

With some debug output I've seen that $filePath is empty string at this place but I have not found out yet why: https://github.com/joomla-extensions/patchtester/blob/4.0-dev/administrator/components/com_patchtester/PatchTester/Model/PullModel.php#L274.

avatar richard67 richard67 - change - 19 Oct 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-10-19 13:50:39
Closed_By richard67
avatar richard67 richard67 - close - 19 Oct 2019
avatar richard67
richard67 - comment - 19 Oct 2019

Closing because having PR #242 .

Add a Comment

Login with GitHub to post a comment