avatar mbabker
mbabker
18 Oct 2019

The patchtester.js file was changed for the sake of changing it, I can't deduce any other valid explanation for why it was changed. It also removed a very explicit warning message when using the reset function.

This is why there should be a reason for change and not just "oh this is the flavor of the day well cool beans". Not to mention code reviews, because anyone would've seen that removal if they had looked for more than half a second.

avatar mbabker mbabker - open - 18 Oct 2019
avatar roland-d roland-d - change - 21 Mar 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-03-21 10:28:44
Closed_By roland-d
avatar roland-d roland-d - close - 21 Mar 2020
avatar roland-d
roland-d - comment - 21 Mar 2020

Good call. I have restored the warning message.

Add a Comment

Login with GitHub to post a comment