Joomla! Issue Tracker - Patch Tester

Download
Launch
Feeling Lucky

[#233] - Non-Platform Portable Code

avatar mbabker
mbabker
18 Oct 2019

patchtester/administrator/components/com_patchtester/PatchTester/Model/PullModel.php

Line 221 in 0a1792d

// Check if zip folder exists on server

There is a HTTP API in Joomla for a reason. Perhaps using it would be good here.

patchtester/administrator/components/com_patchtester/PatchTester/Model/PullModel.php

Line 230 in 0a1792d

file_put_contents($zipPath, fopen($serverZipPath, "r"));

You've now pretty much forced anyone using your vision of this component to turn on URL support for file streams. Well minded administrators disable this functionality.

avatar mbabker mbabker - open - 18 Oct 2019
avatar richard67
richard67 - comment - 10 Nov 2019

@mbabker You mean do it like here: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_joomlaupdate/Model/UpdateModel.php#L397, i.e. use HttpFactory::getHttp()?

avatar richard67
richard67 - comment - 10 Nov 2019

@mbabker Maybe like that: #249 ?

avatar richard67
richard67 - comment - 10 Nov 2019

Please test #249 ;-)

avatar roland-d
roland-d - comment - 21 Mar 2020

This has now been refactored to use the Joomla API.

avatar roland-d roland-d - close - 21 Mar 2020
avatar roland-d roland-d - change - 21 Mar 2020
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-03-21 10:44:41
Closed_By ⇒ roland-d

Add a Comment

Login with GitHub to post a comment