Open the Joomla! Patchtester
Test This Patch in my humble opinion should be Apply/Revert Patch as the user is able to apply or revert the patch there. The testing part is to be done by the user itself manually and not done by the Apply Patch buttonGithub should be changed to Github Link as the latter is more informativeThe above is just my opinion, I request members to comment on this.
The right most column Test This Patch in my humble opinion should be Apply/Revert Patch as the user is able to apply or revert the patch there. The testing part is to be done by the user itself manually and not done by the Apply Patch button
Given that the button text is "Apply Patch", I think that having Apply/Revert Patch as column title would work.
Also the column for Github should be changed to Github Link as the latter is more informative
In this case, I'd stay with GitHub also because the other colum is Issue Tracker (without link) and is fine.
@jeckodevelopment should I do a PR for the same
The change happens in the button wich is Apply when the pr is not yey applyied and Revert when the pr has been applyed... so imho it's quite clear
The change happens in the button wich is Apply when the pr is not yey applyied and Revert when the pr has been applyed... so imho it's quite clear
@alikon but the the last column name is not suggestive of what the buttons do over there. Test This Patch does not clearly define the column there
feel free to submit a pr i'm only expressing my POV
To be honest, I don't like the "Apply/Revert Patch" label any better than I do the current one.
And if I'm also being totally honest, I don't like how the GitHub and Issue Tracker column headers are essentially the same text as the cells they label just with different markup structure (and yes, this is me saying the "J! Issue" button text should change). I'm also fairly sure having these marked up in a way that looks like buttons fails accessibility (they're links and should look like such), but that's now derailing this issue.
In all honesty I don't really care, just looking at things right now I can say I don't really like either the current label or the proposed "Apply/Revert Patch" label.
In that case I think we should leave the things as they are
If someone's got an idea, please feel free to submit it. I'm just providing my feedback here, and right now personally I just feel like both labels are "m'eh", they aren't great but they aren't terrible.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-21 10:10:33 |
| Closed_By | ⇒ | roland-d |
The Github and Issue tracker columns have been removed by now and as for the labels I agree with Michael here.
Closing this as things can be left as they are.
@mbabker @wilsonge @jeckodevelopment