avatar SniperSister
SniperSister
8 Sep 2018

Steps to reproduce the issue

Try to setup the credential based login, configure your Github account to use a password with a "#" somewhere in the string. Fetch the list of issues.

Expected result

Issuelist is being fetched.

Actual result

You'll get a connection error.

Additional comments

Add the first glance it looks like the issue is being caused by the lack of encoding for the # character while setting up the connection:
https://github.com/joomla-extensions/patchtester/blob/master/administrator/components/com_patchtester/PatchTester/GitHub/GitHub.php#L88

This leads to a URL like this being used for the connection:

user:pass#word@github.com

The url gets truncated after the #, because that's used for html anchors.

A simple

$password = str_replace('#', '%23', $password);

Should fix it, for both, username and password

avatar SniperSister SniperSister - open - 8 Sep 2018
avatar mbabker
mbabker - comment - 9 Sep 2018

Fixed by #215

avatar mbabker mbabker - change - 9 Sep 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-09-09 15:26:58
Closed_By mbabker
avatar mbabker mbabker - close - 9 Sep 2018
avatar mbabker mbabker - close - 9 Sep 2018

Add a Comment

Login with GitHub to post a comment