User tests: Successful: Unsuccessful:
Pull Request for Issue #210.
add a new option to filter PR's only from a branch
maybe should be better to properly use the Github API
yes, it should be better fetched directly from the github API
Without changing the lookup mechanism to use GitHub's GraphQL API instead of the REST API (which inherently removes the ability to pull data without requiring GitHub credentials in the component), we can't optimize the API lookups. So to me, without the ability to do that, this is just an artificial filter to not save some data to the database. To me the only improvement is it saves you from having to use the "Filter Target Branch" UI filter.
correct
so you can't avoid downloading unnecessary PR?
Right now, no, there is no way to avoid downloading extra data. There is a way to change the API query, but as I said it has the side effect of removing the ability to fetch data without saving your GitHub credentials to the component configuration. I don't want to remove that feature right now.
as stated, without changing the github lookup no, with this pr we can only avoid to store "unnecessary" pr's on db
got it, thanks Guys for Info. So its easiest to stay as is.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-09 09:39:26 |
| Closed_By | ⇒ | alikon |
OK, looking at this again, what is really being gained here? We don't limit the number of API calls to GitHub and there is already a display filter for branches in the current code.