avatar franz-wohlkoenig
franz-wohlkoenig
15 Feb 2017

Steps to reproduce the issue

Click "Fetch Data", in Modal-Window stops at Processing page 1 of GitHub data. Quit Modal-Window and reload Patchtester-Tab get PRs.

System information (as much as possible)

Joomla! 4.0-nightly builds
macOS Sierra, 10.12.3
Safari 10.0.3
PHP 7.0.15

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35
avatar franz-wohlkoenig franz-wohlkoenig - open - 15 Feb 2017
avatar mbabker
mbabker - comment - 15 Feb 2017

As the notification says, patch tester support on 4.0 is experimental at best right now. It isn't feasible to keep it in sync with 4.0 while it's still undergoing changes (actually a proper 4.0 layout wasn't even added to the code until after the last beta was tagged, and that doesn't yet include JavaScript changes that are required).

It seems someone has busted the JavaScript in core.js. Or there's some other B/C break with the new JavaScript and/or template that has to be reverse engineered since right now there is zero documentation on the changes.

Uncaught TypeError: Cannot read property 'joomla.jtext' of null
    at Object.Joomla.getOptions (core.js?1fef521…:129)
    at Object._ (core.js?1fef521…:74)
    at Object.error (fetcher.js?1fef521…:81)
    at fire (jquery.js?1fef521…:3305)
    at Object.fireWith [as rejectWith] (jquery.js?1fef521…:3435)
    at done (jquery.js?1fef521…:9244)
    at XMLHttpRequest.<anonymous> (jquery.js?1fef521…:9484)
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Feb 2017

thanks @mbabker

avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Feb 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-02-15 13:38:29
Closed_By franz-wohlkoenig
avatar franz-wohlkoenig franz-wohlkoenig - close - 15 Feb 2017
avatar franz-wohlkoenig franz-wohlkoenig - close - 15 Feb 2017
avatar zero-24
zero-24 - comment - 15 Feb 2017

@C-Lodder @dgt41 can you help here with a JavaScript migration guide for 4.0?

avatar zero-24
zero-24 - comment - 15 Feb 2017

@franz-wohlkoenig i think we should keep this open as this is still a issue even if the 4.0 support is experimental ?

avatar mbabker
mbabker - comment - 15 Feb 2017

The experimental warning is really just more to say "don't expect everything to work right all the time", not "it's 4.0, no bug fixes ever".

avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Feb 2017
Status Closed New
Closed_Date 2017-02-15 13:38:29
Closed_By franz-wohlkoenig
avatar franz-wohlkoenig franz-wohlkoenig - reopen - 15 Feb 2017
avatar franz-wohlkoenig franz-wohlkoenig - reopen - 15 Feb 2017
avatar mbabker
mbabker - comment - 22 Apr 2017

Turns out this wasn't a JavaScript error, rather a minor B/C break between JHttpResponse in 3.x and Joomla\Http\Response in 4.0. This is fixed, though I could still use help with the JavaScript migration.

avatar mbabker mbabker - change - 22 Apr 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-04-22 17:10:51
Closed_By mbabker
avatar mbabker mbabker - close - 22 Apr 2017
avatar mbabker mbabker - close - 22 Apr 2017

Add a Comment

Login with GitHub to post a comment