avatar coaleb
coaleb
14 Jul 2016

I don't know if this has always been the case with Patch Tester, but when you apply patches, it is unable to revert the changes. In my specific case:

I applied PR 10391, it applied successfully, but since I was just 'testing' I clicked revert to revert the changes made by the PR.

The expected result was that the PR would revert and all is forgiven.

The actual result was this error:
PatchTester\Model\PullModel::revert - Error retrieving table data ([])

...and the patch is still applied.

Joomla 3.6.0 Stable
Patch Tester 3.0.0 Alpha
PHP 5.5.36
MySQL 5.5.45-cll-lve
Apache/2.4.18

In a side note, I did not actually intend to test this PR, the only reason I applied it was because I was trying to see if ANYTHING would apply. Every PR I attempted to apply prior to this one resulted in this error:
"Could not connect to GitHub: No commit found for the ref [ref...]"

avatar coaleb coaleb - open - 14 Jul 2016
avatar mbabker
mbabker - comment - 14 Jul 2016

Please use the stable package unless you're purposefully trying to test the
new version. There's been a couple of bug fixes since the alpha tag and
it's definitely not battle tested yet.

On Thursday, July 14, 2016, coaleb notifications@github.com wrote:

I don't know if this has always been the case with Patch Tester, but when
you apply patches, it is unable to revert the changes. In my specific case:

I applied PR 10391, it applied successfully, but since I was just
'testing' I clicked revert to revert the changes made by the PR.

The expected result was that the PR would revert and all is forgiven.

The actual result was this error:
PatchTester\Model\PullModel::revert - Error retrieving table data ([])

...and the patch is still applied.

Joomla 3.6.0 Stable
Patch Tester 3.0.0 Alpha
PHP 5.5.36
MySQL 5.5.45-cll-lve
Apache/2.4.18

In a side note, I did not actually intend to test this PR, the only reason
I applied it was because I was trying to see if ANYTHING would apply. Every
PR I attempted to apply prior to this one resulted in this error:
"Could not connect to GitHub: No commit found for the ref [ref...]"


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#166, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAWfoS79CNFDDOJn2cPclcF7Rdp2xFbYks5qVsMLgaJpZM4JM8IY
.

avatar coaleb
coaleb - comment - 15 Jul 2016

Got it. I was actually trying to test a PR, so I went back to the stable version, and everything worked great. Thanks for the heads up!

avatar coaleb coaleb - change - 20 Jul 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-07-20 15:44:25
Closed_By coaleb
avatar coaleb coaleb - close - 20 Jul 2016
avatar coaleb coaleb - close - 20 Jul 2016

Add a Comment

Login with GitHub to post a comment