avatar roland-d
roland-d
29 Jun 2016

Steps to reproduce the issue

  1. Download the 3.0.0-alpha zip package
  2. Install it via the Joomla Extension manager

Expected result

A successful installation message

Actual result

A Fatal error:
patchtester_fatal_error

System information (as much as possible)

PHP Built On Windows NT CABERAWIT 10.0 build 10240 (Windows 10) AMD64
Database Version 5.7.9
Database Collation utf8_general_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 5.6.16
Web Server Apache/2.4.17 (Win64) PHP/5.6.16
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.5.1 Stable [ Unicorn ] 05-April-2016 22:45 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0

Additional comments

avatar roland-d roland-d - open - 29 Jun 2016
avatar MATsxm
MATsxm - comment - 29 Jun 2016

@roland-d
See in the README that

Minimum supported Joomla! version is now 3.6

I guess this is a start of explaination

avatar mbabker
mbabker - comment - 29 Jun 2016

Yep. The install script relies on joomla/joomla-cms@e05aa66 to have been merged.

I thought about checking for the class' existence and throwing an exception but the calls to JInstallerAdapter::setupScriptfile() aren't wrapped in a try/catch so that exception would bubble up the call stack and instead of a graceful abort of the extension install it would hard fail partway through. I could stub it, but then that defeats the point of using it IMO. And sadly, there isn't any way to tell the installer any sooner that the extension is only supported on X version of Joomla. I've got a rock on one side and a hard place on the other.

avatar roland-d
roland-d - comment - 29 Jun 2016

@MATsxm Thanks for that. I did check the commit history but missed the README.

@mbabker No worries, will check it another time on 3.6.

avatar mbabker
mbabker - comment - 6 Sep 2016

Closing. Without backing out the changes that use the core installer script, there isn't anything "good" that can be done here.

avatar mbabker mbabker - change - 6 Sep 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-09-06 00:01:52
Closed_By mbabker
avatar mbabker mbabker - close - 6 Sep 2016
avatar mbabker mbabker - close - 6 Sep 2016

Add a Comment

Login with GitHub to post a comment