avatar izharaazmi
izharaazmi
15 Jun 2016

Add a details view showing the discussion thread and tags. This could be a minimal layout which gives details relates for the patch.

If not much then it could be even:

  • An Iframe showing the github PR page.
  • A modal showing the first (or more) comments formatted according to the github markdown style.
avatar izharaazmi izharaazmi - open - 15 Jun 2016
avatar mbabker
mbabker - comment - 15 Jun 2016

That's exactly why the "GitHub" and "J! Issue" buttons are on the list view. You're taken directly to the relevant item on those two sites.

I'm not adding code to pull the entire issue thread when fetching data. The number of API requests to pull that off is too many and in general if it causes things to stop working with anonymous API requests I'm not doing it.

avatar izharaazmi
izharaazmi - comment - 15 Jun 2016

Loved the phrase "I'm not doing it." ?

I understand its a waste calling apis for more details. However, the actual list api call which get you the list of pulls returns the initial comment and more other relevant details already. Can't we use it for quick lookup within the component? For more information user always has a choice to go relevant pages.

avatar mbabker
mbabker - comment - 15 Jun 2016

The first couple hundred characters of the issue's description are used as a tooltip on the issue's title. Issue is it's still in markdown format (because it would need added API calls to convert it to HTML or inclusion of a PHP markdown library to parse it into plain text), so with the standardized template it's not useful at all anymore.

I hesitate to make it something that can display inline because some of the issue bodies get excessively long, especially when folks copy/paste the output from the sys info text file into the issue instead of adding it as a file attachment. Plus, again rendering it means doing something to convert the markdown into a human readable format.

Ya, it's a little slow to click a button and go to a third party website, but all of the issue context can be found there. And to me that's still a better option than giving a small snippet of data in the component which may not have all the needed information to do anything with an issue.

screen shot 2016-06-15 at 8 02 21 am

avatar mbabker mbabker - change - 8 Oct 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-10-08 15:11:48
Closed_By mbabker
avatar mbabker mbabker - close - 8 Oct 2016
avatar mbabker mbabker - close - 8 Oct 2016

Add a Comment

Login with GitHub to post a comment