Success

User tests: Successful: Unsuccessful:

avatar photodude
photodude
17 Dec 2015

Need to move the is_numeric($search) check to it's own condition since we are not striping off the first 3 characters when searching by a pure numeric case
Also better to search with a "like" rather than a direct equals so we can match partial number sequences.

This resolves an unnoticed inconsistency with #118

avatar photodude photodude - open - 17 Dec 2015
avatar photodude
photodude - comment - 17 Dec 2015

@mbabker Thanks, I have made that correction too.

avatar mbabker mbabker - change - 17 Dec 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-12-17 17:07:25
Closed_By mbabker
avatar mbabker mbabker - close - 17 Dec 2015
avatar mbabker mbabker - reference | c2681fd - 17 Dec 15
avatar mbabker mbabker - merge - 17 Dec 2015
avatar mbabker mbabker - close - 17 Dec 2015
avatar photodude photodude - head_ref_deleted - 17 Dec 2015

Add a Comment

Login with GitHub to post a comment