avatar photodude
photodude
16 Dec 2015

All attempts to search/filter by Pull ID result in "No Matching Results" (even when I am looking right at the pull id I search for) with the current release Patch Tester 2.0.0.beta4

avatar photodude photodude - open - 16 Dec 2015
avatar mbabker
mbabker - comment - 16 Dec 2015

Enable debug mode and check what queries are being made. That should help identify the issue.

avatar photodude
photodude - comment - 16 Dec 2015

Maybe this is the source?
patcherror

avatar mbabker
mbabker - comment - 16 Dec 2015

The query's right. For your filter it is looking for titles containing 5837. If you want to look it up by ID, use id:5837 in the filter box (the same way most core components work).

avatar photodude
photodude - comment - 16 Dec 2015

Generally I consider requiring additional perimeters for a search field questionable for UI/UX.
An OR in the query should allow for searching by either title or ID without needing the additional prefix.
There is also no tool tip or other information specifying the necessity of a prefix for ID searching.

Generally speaking I doubt most people are searching core components by ID, although the tool tip does specify the prefix as an option.

Adding a tool tip to explain the use of the id: prefix and maybe changing lin 131 in the model PullsModel.php
from if (stripos($search, 'id:') === 0) to something like if (stripos($search, 'id:') === 0 || is_numeric($search))

avatar mbabker
mbabker - comment - 16 Dec 2015

It was done differently before (see 76de180 which changed it to follow the core convention), but that caused issues too. Updating the tooltip or adding the is_numeric check isn't a major issue I'd say.

avatar mbabker mbabker - close - 17 Dec 2015
avatar mbabker mbabker - change - 17 Dec 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-12-17 02:52:39
Closed_By mbabker
avatar mbabker mbabker - close - 17 Dec 2015

Add a Comment

Login with GitHub to post a comment