Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
25 Nov 2015

@schnuti @peteruoi can you test here?

This should fix the issue #107

How to test

  • enter e.g. id:1234 to the seach.
  • you got an error
  • apply this change (by changing the file direct on your file system)
  • try again ;)

Thanks.

avatar zero-24 zero-24 - open - 25 Nov 2015
avatar peteruoi
peteruoi - comment - 25 Nov 2015

i tried again but whenever i search for a string such as "id"
a message like
You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':8538)' at line 4 SQL=SELECT COUNT(*) FROM fxowe_patchtester_pulls AS a LEFT JOIN fxowe_patchtester_tests AS t ON t.pull_id = a.pull_id WHERE (a.title LIKE '%id:8538%') OR (a.pull_id = id:8538)
appears.
Maybe the cause is that the xamp environment i installed has mariadb as default?
Anyway, it worked fine when i just searched for an id like "8538".
The fix however didn't make any difference for my case :)

avatar zero-24
zero-24 - comment - 26 Nov 2015

@peteruoi you need to change the code here: administrator/components/com_patchtester/PatchTester/Model/PullsModel.php;) I have just tested it and it fixes the issue for me ;) Please make also sure you use the last version of com_patchtester.

@mbabker can you consider to merge this for a new release? This allows us to search via ID. Currently we find nothing as we just escape the id ;) Thanks.

3ba6de4 26 Nov 2015 avatar zero-24 cs
avatar peteruoi
peteruoi - comment - 30 Nov 2015

It works fine! Before i updated the PullModel and not the pullsmodel.
Its ok now, both id and string! Thanks!

avatar zero-24 zero-24 - close - 4 Dec 2015
avatar zero-24 zero-24 - change - 4 Dec 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-12-04 22:39:47
Closed_By zero-24
avatar zero-24 zero-24 - close - 4 Dec 2015

Add a Comment

Login with GitHub to post a comment