Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#9991] - Fix for #9832 + content embedded in a container div

? Success
Pull Request for # 9832

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
19 Apr 2016

Pull Request for Issue #9832 .

Summary of Changes

When Bootstrap modal loads an iframe, BS tooltips with placement top are truncated at the top border of the iframe. (no auto placement in BS2)
This PR sets the tooltip placement to bottom.
In the same time, content is embedded in a container div (using already existing container-popup class for modal.php)

Testing Instructions

Go to: Components > Messaging > click on Settings button to open this modal.

Before Patch:
capture d ecran 2016-04-19 a 17 11 43

After Patch:
capture d ecran 2016-04-19 a 17 38 26

avatar JoomliC JoomliC - open - 19 Apr 2016
avatar JoomliC JoomliC - change - 19 Apr 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Apr 2016
Labels Added: ?
avatar JoomliC JoomliC - change - 19 Apr 2016
Title
…
Fix for #9832 + embed modal content as container
Fix for #9832 + content embedded in a container div
avatar JoomliC JoomliC - change - 19 Apr 2016
Title
…
Fix for #9832 + embed modal content as container
Fix for #9832 + content embedded in a container div
avatar andrepereiradasilva andrepereiradasilva - test_item - 19 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Apr 2016

I have tested this item :white_check_mark: successfully on a9c4e02

works as described. thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9991.

avatar brianteeman brianteeman - change - 19 Apr 2016
Category ⇒ Templates (admin)
avatar richard67 richard67 - test_item - 19 Apr 2016 - Tested successfully
avatar richard67
richard67 - comment - 19 Apr 2016

I have tested this item :white_check_mark: successfully on a9c4e02

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9991.

avatar JoomliC
JoomliC - comment - 19 Apr 2016

Thanks @andrepereiradasilva and @richard67 for testing :+1:
Another one in this series started: Versions modal #9995 ;-)

avatar brianteeman brianteeman - change - 19 Apr 2016
Rel_Number 0 ⇒ 9832
Relation Type ⇒ Pull Request for
avatar brianteeman brianteeman - change - 19 Apr 2016
Category Templates (admin) ⇒ Templates (admin) UI/UX
avatar brianteeman brianteeman - change - 19 Apr 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 19 Apr 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9991.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 19 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - reference | b70dff5 - 19 Apr 16
avatar rdeutz rdeutz - merge - 19 Apr 2016
avatar rdeutz rdeutz - close - 19 Apr 2016
avatar rdeutz rdeutz - change - 19 Apr 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-19 18:23:18
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 19 Apr 2016
avatar rdeutz rdeutz - merge - 19 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 19 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 19 Apr 2016
Labels Removed: ?
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment