Just as with position it is possible to set pages to ::none::
So there needs to be a way to select ::none:: from the filter

ok, you're right, makes sense. will check that.

ok done. We have an option to select the modules not assigned to any pages now too.

I have tested this item successfully on fe3b973

All good.

Just think it would be better if instead of "No pages" it would be the same as with positions and be ":: None ::"

Just think it would be better if instead of "No pages" it would be the same as with positions and be ":: None ::"

IMO that could be confusing. Because that is a term used in the positions.

We could use "None" (instead of "No pages") like in the column when you have a module not assigned to any menu if you prefer. Please tell me what you prefer, i can easily chnage it.

I will leave it to someone else to decide which option

@brianteeman BTW did you test on postgresql ?

Not yet - i forgot - testing that for you now

As far as I can see it works well in postgres

I have tested this item successfully on fe3b973

All good.

Just think it would be better if instead of "No pages" it would be the same as with positions and be ":: None ::"

All good.

Just think it would be better if instead of "No pages" it would be the same as with positions and be ":: None ::"

@andrepereiradasilva if you make the change to ::none:: I will set this RTC

This PR has received new commits.

CC: @brianteeman, @MDXBilal12

@brianteeman done. See 28183f5

Not at my desk but looking at the code doesn't that produce ::::none::::
On 20 Apr 2016 12:36 pm, "andrepereiradasilva" notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman done. See 28183f5
28183f5

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9987 (comment)

look again

I have tested this item successfully on 28183f5

As I said I was checking from my phone ;) All good

Setting RTC as the only change since the last tests was a language string

I have tested this item successfully on 28183f5

I am removing the RTC from this as there is an issue with a confusing Pages filter being present when viewing admin modules only

Can you add the admin fix you made for com_templates please

This PR has received new commits.

CC: @brianteeman, @MDXBilal12

As requested, applied the same changes that i did in the other PR and the new filter now should only appear when "Site" is selected. Please test.

That works but do we even need the pages column on that view?

On 1 May 2016 at 20:53, andrepereiradasilva notifications@github.com
wrote:

As requested, applied the same changes that i did in the other PR and the
new filter now should only appear when "Site" is selected. Please test.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9987 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

This PR has received new commits.

CC: @brianteeman, @MDXBilal12

This PR has received new commits.

CC: @brianteeman, @MDXBilal12

Removed pages column from admin view as requested.

I have tested this item successfully on 56cd264

@MDXBilal12 can you please test just the latest change and mark the test ?

Latest changes:
1. Removed "Pages" column when admin modules is selected
2. The new filter does not appear when admin modules is selected

needs one mroe tester here.

I have tested this item unsuccessfully on 56cd264

The filter "all except selected" doesn't work:
Create a module with this setting (I enabled the "about joomla" pages)
In filter, choose one page that you selected in the module settings (f. ex. "Getting started".
The module still displays.

Could not reproduce your problem. I did this:

1. Created a module (latest articles type) with:

   Module Assignment: On all pages except those selected
   Menu Selection: Just "Getting Starting" page selected

2. In modules list view, selected in the new - Select Page - filter "Getting Starting" and the new module isn't there (as it should).

   If i choose any other page (except none) the module is there (as it should).

Could you do a step by step guide of your test so to understand the issue?

I created a module with this settings:

As you can see, the page "Getting started" is selected, which means the module isn't assigned to this page.

After that, I switched to the modules view. After applying the filter, I got this:

In my view, the module "LastModuleTest" shouldn't been displayed here.

you're right, it's a bug.
it happens when more than one menu item is selected in "all except".
will check.

This PR has received new commits.

CC: @brianteeman, @grhcj, @MDXBilal12

This PR has received new commits.

CC: @brianteeman, @grhcj, @MDXBilal12

sorry, please check now

I have tested this item ✅ successfully on 7e37a19

I have tested this item ✅ successfully on 7e37a19

RTC - cool new feature

Taking off RTC for now until code fixes are implemented.

This PR has received new commits.

CC: @brianteeman, @grhcj, @MDXBilal12

done @roland-d

@roland-d can we have the RTc back on this one. Only did the changes you requested.

@andrepereiradasilva I am having a conflict:

error: patch failed: layouts/joomla/searchtools/default/filters.php:11
error: layouts/joomla/searchtools/default/filters.php: patch does not apply

Would you mind checking if there is a conflict with current staging?

strange let me update the branch

This PR has received new commits.

CC: @brianteeman, @grhcj, @MDXBilal12

ok @roland-d try now.

@andrepereiradasilva The fatal error is gone but I have a whitespace error now :)

<stdin>:108: trailing whitespace.
                                        (' . $subQuery1 . ') = 0
warning: 1 line adds whitespace errors.

In addition I have a failure in my test, see this screenshot:

The menu is called About Joomla and I think we should keep the same name rather than an internal name. What do you think?

This PR has received new commits.

CC: @brianteeman, @grhcj, @MDXBilal12

you're more efficient than travis! whitespace removed

@roland-d

The menu is called About Joomla and I think we should keep the same name rather than an internal name. What do you think?

I think so. But thats's all across joomla menu field selector (in all views that use it).
Nothing to do with my PR. That is for another PR.

I will make a PR to change that in all menu select fields

@roland-d new PR for that #10625 please test

If we do that everywhere then best to resolve that in a separate email

This should be tested in other databases than MySQL (PostgreSQL or MSSQL). Because we may have to add more fields to the select statement due to the added having clause.
MySQL allows to do stuff here which PostgreSQL doesn't allow.

Thanks everybody