[#9984] - [com_users] notes view: Add max level filter
- Fixed in Code Base
- 2 May 2016
- Medium
- Build: staging
- # 9984
- Diff
- andrepereiradasilva:com_users_notes-maxlevel
- Pending continuous-integration/travis-ci/pr The Travis CI build is in progress Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
All backend views that are or are associated with tree like structures (e.g. menus, categories) should have a max level filter.
This is valid currently for:
- com_menus items view
- com_content articles view
- com_content featured view
- com_tags tags view
So, this PR is a part of series of PR to add that filter in the views that use categories:
- com_contacts contacts view (RTC #9975)
- com_banners banners view (RTC #9977)
- com_newsfeeds newsfeeds view (RTC #9978)
- com_notes notes view (this PR)
- com_banners tracks view (#10009)
Testing Instructions
- Use latest staging and apply this patch
- Create some user notes categories with at least two levels
- Create some user notes and associate them to the categories created in 2..
- Test the new max levels filter.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item 
successfully on 86c5fc5
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
and thanks again for testing!
@andrepereiradasilva I know you have no non-utf8mb4 database available to help me with testing my PR 9847 (not wanna link it here because not related to this here), but maybe you could set up such?
If your PHP versions and MySQL versions are coupled somehow (e.g. because using a common package like XAMPP for that), and you use some kind of virtual machiens (VMware or so), you could set up a VM with old stuff for the database server and with new stuff (for fulfilling 3.5.x requirements) for the Joomla! installation, which looks at the old db server.
The test itself then would not need much time, and you could keep the VM with the old db server for later use (when I make my next big PR for handling utf8mb4 conversion for extensions). You know, there is a lack of good experienced testers having such old mysql versions.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
| Category | ⇒ | Components UI/UX |
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Labels | |||
| Milestone |
Added: |
||
technically this is a new feature and it doesn't fix a bug so it has to go into 3.6.0
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have tested this item successfully on 86c5fc5
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
| Labels |
Added:
?
|
||
@aaleksanyants cloud you please check the merge conflicts, thanks
Ups wrong name @andrepereiradasilva cloud you please check the merge conflicts, thanks
This PR has received new commits.
CC: @brianteeman, @MDXBilal12, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
This PR has received new commits.
CC: @brianteeman, @MDXBilal12, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
This PR has received new commits.
CC: @brianteeman, @MDXBilal12, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
This PR has received new commits.
CC: @brianteeman, @MDXBilal12, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
This PR has received new commits.
CC: @brianteeman, @MDXBilal12, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
This PR has received new commits.
CC: @brianteeman, @MDXBilal12, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
This PR has received new commits.
CC: @brianteeman, @MDXBilal12, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.
finally ... conflicts fixed
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 09:00:55 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 86c5fc5
Not sure it is really needed but it is consistent
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9984.