[#9977] - [com_banners] banners view: Add max level filter
- Fixed in Code Base
- 2 May 2016
- Medium
- Build: staging
- # 9977
- Diff
- andrepereiradasilva:com_banners_banners_maxlevels
- Pending continuous-integration/travis-ci/pr The Travis CI build is in progress Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
All backend views that are or are associated with tree like structures (e.g. menus, categories) should have a max level filter.
This is valid currently for:
- com_menus items view
- com_content articles view
- com_content featured view
- com_tags tags view
So, this PR is a part of series of PR to add that filter in the views that use categories:
- com_contacts contacts view (RTC #9975)
- com_banners banners view (this PR)
- com_newsfeeds newsfeeds view (RTC #9978)
- com_notes notes view (RTC #9984)
- com_banners tracks view (#10009)
Testing Instructions
- Use latest staging and apply this patch
- Create some banners categories with at least two levels
- Create some banners and associate them to the categories created in 2..
- Test the new max levels filter.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Components UI/UX |
I have tested this item 
successfully on 3051f44
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9977.
@brianteeman @richard67 thanks for testing again!
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
technically this is a new feature and it doesn't fix a bug so it has to go into 3.6.0
| Labels |
Added:
?
|
||
@andrepereiradasilva cloud you please check the merge conflicts, thanks
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9977.
conflicts fixed
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9977.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 08:47:45 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 3051f44
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9977.