Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#9971] - [com_redirect] links view: searchtools ordering, bug corrections and some improvements

? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
18 Apr 2016

Description

This PR adds, for consistency, as it exists in so many other views in the backoffice, the order select box of the search tools to com_redirect links view.

Also:

  • moves the system messages to the view (removes then from the template)
  • fixes several bugs in searchtools
  • correct visual on mobile, tablet and desktop
  • other small graphical issues.
Before PR

image

After PR

image

Testing Instructions

  1. Install latest staging and apply this patch
  2. Go to Components -> Redirect
  3. Check the message with and without redirect plugin enabled, and with or without collect URL enabled.
  4. Check the search, filtering, ordering and limits are working fine.
  5. Test desktop, tablet and mobile view (ex: reduce browser width).
avatar andrepereiradasilva andrepereiradasilva - open - 18 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 18 Apr 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2016
Labels Added: ? ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 18 Apr 2016

the travis error is something related to PHP7 not related to this PR i think

$ phpenv global 7.0
rbenv: version `7.0' not installed
The command "phpenv global 7.0" failed and exited with 1 during .
Your build has been stopped.
avatar mbabker
mbabker - comment - 18 Apr 2016

Probably related to http://news.php.net/php.internals/92406

avatar andrepereiradasilva
andrepereiradasilva - comment - 18 Apr 2016

yeah it seems so, thanks

avatar andrepereiradasilva
andrepereiradasilva - comment - 18 Apr 2016

now it's ok.

avatar brianteeman brianteeman - change - 19 Apr 2016
Category ⇒ Components UI/UX
avatar brianteeman brianteeman - change - 19 Apr 2016
Labels
avatar brianteeman brianteeman - change - 19 Apr 2016
Category Components UI/UX ⇒ Components Language & Strings UI/UX
avatar brianteeman brianteeman - test_item - 19 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Apr 2016

I have tested this item :white_check_mark: successfully on c61530b

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9971.

avatar brianteeman brianteeman - test_item - 19 Apr 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 19 Apr 2016

I have tested this item :red_circle: unsuccessfully on c61530b

After applying the patch the "Batch" button on the toolbar is removed

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9971.

avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Apr 2016

After applying the patch the "Batch" button on the toolbar is removed

Ahh? it's not removed....

image

avatar brianteeman
brianteeman - comment - 19 Apr 2016

It is for me - will check to make sure I am on current staging

avatar MATsxm MATsxm - test_item - 19 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 19 Apr 2016

I have tested this item :white_check_mark: successfully on c61530b

Thanks
(Batch's here for me)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9971.

avatar brianteeman brianteeman - test_item - 19 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Apr 2016

I have tested this item :white_check_mark: successfully on c61530b

Weird - must have been something in my install. ITs all ok. Sorry for confusion

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9971.

avatar brianteeman brianteeman - change - 19 Apr 2016
Status Pending ⇒ Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 19 Apr 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9971.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 19 Apr 2016
Milestone Added:
avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Apr 2016

@MATsxm @brianteeman thanks for testing!

avatar rdeutz rdeutz - reference | 412d3a7 - 19 Apr 16
avatar rdeutz rdeutz - merge - 19 Apr 2016
avatar rdeutz rdeutz - close - 19 Apr 2016
avatar rdeutz rdeutz - change - 19 Apr 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-19 11:45:46
Closed_By ⇒ rdeutz
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 19 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment