? ? Pending

User tests: Successful: Unsuccessful:

avatar chrisdavenport
chrisdavenport
17 Apr 2016

Summary of Changes

Some language strings in Smart Search are intended to be used as clauses within a constructed sentence. Although they look like sentences in their own right, this is not how they are used and hence they should not end in full stops.

The sentence is assembled here: https://github.com/joomla/joomla-cms/blob/staging/components/com_finder/helpers/html/query.php

These language strings are not used anywhere else.

Testing Instructions

  • Make sure you have Smart Search enabled and some content indexed.
  • Make sure you have "Query explanation" set to "Yes" in a menu item or in the global options.
  • Enter a search term (eg. "the"). The query explanation given will be something like this: "Assuming the is required., the following results were found.". Note the full stop after "required".
  • Apply this PR.
  • Repeat the search and you should see: "Assuming the is required, the following results were found.".
  • Similarly for the other clauses.
avatar chrisdavenport chrisdavenport - open - 17 Apr 2016
avatar chrisdavenport chrisdavenport - change - 17 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2016
Labels Added: ? ?
avatar Hils
Hils - comment - 17 Apr 2016

Will do! I just get confused sometimes when things are committed with no tests. Sorry!

avatar brianteeman brianteeman - change - 19 Apr 2016
Category Language & Strings
avatar brianteeman brianteeman - change - 19 Apr 2016
Labels
avatar brianteeman brianteeman - test_item - 19 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Apr 2016

I have tested this item :white_check_mark: successfully on 3dbf27c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9957.

avatar brianteeman brianteeman - change - 20 Apr 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 20 Apr 2016

Setting RTC as it is an obvious fix


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9957.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 20 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 9c5ab09 - 20 Apr 16
avatar rdeutz rdeutz - merge - 20 Apr 2016
avatar rdeutz rdeutz - close - 20 Apr 2016
avatar rdeutz rdeutz - change - 20 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-20 11:25:55
Closed_By rdeutz
avatar chrisdavenport chrisdavenport - head_ref_deleted - 20 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment