[#9951] - [com_banners] tracks view: searchtools ordering and bug corrections
- Fixed in Code Base
- 19 Apr 2016
- Medium
- Build: staging
- # 9951
- Diff
- andrepereiradasilva:com_banners_tracks_searchtools
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
This PR corrects bugs in the com_banners tracks views searchtools and matches the searchtools layout with other views.
Before PR
After PR
How to test
- Use latest staging
- Create banners clients, then create some banners and associate with those clients
- Confirm you have some banner tracks for the tests (see note below)
- Go to Components -> Banners -> Tracks
- Check there are several bugs in the searchtools
- Apply patch
- Check the search, ordering select box and the filters are working fine.
- Test desktop, tablet and mobile view (ex: reduce browser width).
Note: If you don't have tracks records you can generate some in the database (#__banners_tracks table), example:
INSERT INTO `<prefix>_banner_tracks` (`track_date`, `track_type`, `banner_id`, `count`) VALUES ('2016-04-11 00:00:00', '1', '1', '5');
INSERT INTO `<prefix>_banner_tracks` (`track_date`, `track_type`, `banner_id`, `count`) VALUES ('2016-01-11 00:00:00', '2', '1', '7');
INSERT INTO `<prefix>_banner_tracks` (`track_date`, `track_type`, `banner_id`, `count`) VALUES ('2015-04-11 00:00:00', '2', '2', '9');
INSERT INTO `<prefix>_banner_tracks` (`track_date`, `track_type`, `banner_id`, `count`) VALUES ('2016-02-11 00:00:00', '2', '2', '12');| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Category | ⇒ | Components UI/UX |
| Labels | |||
| Labels | |||
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9951.
@franz-wohlkoenig just added a better hint (placeholder) in the begin and end date filters.
IMO, your test remains a success.
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9951.
I have applied this PR and found that "clear" button dose not clear the selected "Begin date" and "End date" filters.
Otherwise PR successfully added search tool as per other Joomla layouts.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9951.
@RonakParmar just tried in chrome for windows and it clears the dates.
Please, clear browser cache, test again and, if ok, mark as success.
@andrepereiradasilva I have deleted my browser cache and also tested in private window still not able to clear selected date using "clear" button.
what browser are you using? can you make a small gif video?
@RonakParmar is your problem the same as this one? #7856
I think yes, for begin and end date, calendar is used. So may be because of this issue, I am not able to clear the date filters.
I think this clear button issue is not related with your PR.
@andrepereiradasilva Thanks for the reference issue.
I have tested this item 
successfully on 95a92b6
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9951.
@franz-wohlkoenig can you just mark as tested success again so it as 2 success tests and can go RTC?
I have tested this item successfully on 95a92b6
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9951.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
@RonakParmar @franz-wohlkoenig thanks for testing
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-19 11:32:58 |
| Closed_By | ⇒ | rdeutz |
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 936080a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9951.