[#9904] - Send Test Mail button - Ajax call has always smtpauth = 1
- Fixed in Code Base
- 19 Apr 2016
- Medium
- Build: staging
- # 9904
- Diff
- anibalsanchez:9768--Send-Test-Mail-smtpauth-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9768 / #9803
Summary of Changes
Send Test Mail button does not correctly evaluate "SMTP Authentication" radio. Then, mails are sent via SMTP even when "SMTP Authentication" is disabled.
Fix: smtpauth : $('input[name="jform[smtpauth]"]:checked').val(),
The problem is found when your fill all SMTP credentials and keep "SMTP Authentication"=No... it applies the credentials even when it is disabled.
In this PR, I have modified the code to really check for the "SMTP Authentication" radio value.
Steps to reproduce the issue
- Fill all SMTP fields in Mail Settings for a SMTP server that requires authentication
- But, don't enable SMTP Authentication
- Send Test Mail button sends emails even when the radio is disabled
Testing Instructions
- Fill all SMTP fields in Mail Settings for a SMTP server that requires authentication
- Test it, click on 'Send Test Mail' button to receive an email
- Disable "SMTP Authentication" radio
- Test it, click on 'Send Test Mail' button ... email must not be received and error is shown about the failed authentication
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
@andrepereiradasilva Yes, it is a success! Mail must be rejected when authentication is disabled and the server requires authentication.
I have tested this item 
successfully on 81e541c
as comments above
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9904.
I have tested this item successfully on 81e541c
Mail without authentication is now send with the "send test e-mail" button.
Thx for solving this, I ran into this issue earlier.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9904.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Labels | |||
| Category | ⇒ | Administration |
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-19 11:27:52 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Ok. I tested this.
Without patch i get. Mail is sent (i think is sent with php mail fallback - see #9680) and i get:
With patch i get. Mail is not sent and i get:
So is this a success?