? Success

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
13 Apr 2016

Pull Request for Issue #9893.

Summary of Changes

media/mod_languages/images/si_lk.gif added back

Testing Instructions

Before PR
file media/mod_languages/images/si_lk.gif does not exist
After PR
file media/mod_languages/images/si_lk.gif exist

avatar wojsmol wojsmol - open - 13 Apr 2016
avatar wojsmol wojsmol - change - 13 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 13 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Apr 2016

I have tested this item :white_check_mark: successfully on d7e5440


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9902.

avatar wojsmol wojsmol - change - 13 Apr 2016
Title
add si_lk.gif
Regression: Language flag file si_lk.gif is missing
avatar richard67 richard67 - test_item - 13 Apr 2016 - Tested successfully
avatar richard67
richard67 - comment - 13 Apr 2016

I have tested this item :white_check_mark: successfully on d7e5440


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9902.

avatar brianteeman brianteeman - change - 13 Apr 2016
Category Multilanguage
avatar brianteeman brianteeman - change - 13 Apr 2016
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 13 Apr 2016
Title
Regression: Language flag file si_lk.gif is missing
add si_lk.gif
avatar brianteeman
brianteeman - comment - 13 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9902.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Apr 2016
Milestone Added:
avatar Bakual Bakual - change - 13 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-13 18:22:31
Closed_By Bakual
avatar Bakual Bakual - close - 13 Apr 2016
avatar Bakual Bakual - merge - 13 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Apr 2016
avatar Bakual Bakual - reference | cc44ae1 - 13 Apr 16
avatar Bakual Bakual - merge - 13 Apr 2016
avatar Bakual Bakual - close - 13 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Removed: ?
avatar wojsmol wojsmol - head_ref_deleted - 13 Apr 2016
avatar PhilETaylor
PhilETaylor - comment - 23 Apr 2016

Joomla didn't remove the old (with uppercase) for Backward Compatibility (BC).

This is bad - Joomla SHOULD remove the upper case file, on Windows hosts you cannot have the uppercase and the lowercase file at the same time anyway...

avatar Bakual
Bakual - comment - 24 Apr 2016

This is bad - Joomla SHOULD remove the upper case file, on Windows hosts you cannot have the uppercase and the lowercase file at the same time anyway...

It should, yes. But we can't. And it doesn't really matter if that specific file is there duplicated.
The reason why we can't remove it is exactly the Windows system. On Linux on an update we have both the lowercased and uppercased file, and we could remove the uppercased one. But on Windows we only have one file after the update, the old one got overwritten with the new one. If we now try to remove the uppercased file, we remove the one file that was there, which obviously would be bad to do.

The BC isn't really the issue here.

avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment